Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Wrong initialization of variable modality in X-InstructBLIP's generate() within use_cues statement of joint_video_audio #780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Wrong initialization of variable modality in X-InstructBLIP's generate() within use_cues statement of joint_video_audio #780

wants to merge 2 commits into from

Conversation

globc
Copy link

@globc globc commented Jan 7, 2025 •
edited
Loading

This pull request...

  • fixes a wrong initialization of the variable modality within the use_cues statement of X-InstructBLIP's generate() function in joint_video_audio block by moving the modality loop outside.
  • adds a missing continue in X-InstructBLIP's forward() function. Currently modality embeddings are appended twice to input if the conditions are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@globc