Add invoices to user order details #13
Conversation
orzechdev
force-pushed
the
feature/invoices
branch
from
8a48f23 to
ee25785
Compare
orzechdev
changed the title
| QUERIES.OrderDetails, | ||
| data => data.orderByToken | ||
| ); | ||
| getOrderDetails = ( |
There was a problem hiding this comment.
If those queries have different responses, shouldnt those be separate queries to avoid confusion?
Docstring when you should one query and not another would be helpfull.
There was a problem hiding this comment.
I thought about making just one method for returning order details and depending on the internal SDK state which specifies if a user is logged in or not logged in it would automatically return appropriately different results. Therefore SDK would get rid of the need for determination of available order data based on the login state by the end developer, who implements SDK methods. SDK would make it internally automatically. What do you think about it?
There was a problem hiding this comment.
Ok, that would be consistent with the rest of the queries in the file.
Added conditional query for invoices in order details for logged in user.
PR intended to be tested with API branch:
saleor/saleor#5732