"complete" electron support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.3.2 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@10.3.2...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
If you roll to the HEAD, there should be no need in playwright-electron... |
This is a first step to convert to React.
Source now accounts for various stack trace formats. Network now shows `page.goto` resources.
feat: save/load storage options User can save the storage, and then load the storage in the next script. ```sh npx playwright-cli --save-storage=storage.json open www.needs-login.com npx playwright-cli --load-storage=storage.json codegen www.needs-login.com ```
…: make this handle multiple windows, and play nicely with codegen, which seems to break this...)
…en before installing the Script Generator. monitor for all windows closed, then exit. do not install monitoring in devtools windows.
Marcus10110
force-pushed
the
feature/electron-support
branch
from
cced3d7 to
7ab13b3
Compare
|
I think electron support just works out of the box now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add electron support to the entire playwright-cli tool, by supporting it just as if it was another browser. Unfortunately, it's a little tricky to do so. I have not implemented "openPage" support for electron, instead replying on a different behavior - opening the url on electron launch, rather than in a later call. I haven't checked to find out if that's possible with electron, hopefully it is.
There are a few type problems, there appears to be no type for electron that extends the Browser interface in playwright, instead we just have the electron launcher type, and the ElectronApplication type, neither of which quite map directly to the types provided for the other browsers.
To solve this, i threw together an electronBrowser object which implements the required Browser methods, but like the rest of this PR, it's not complete.