Remove deprecated botorch/generation/gen/minimize

Summary: This has been deprecated since pytorch#1352.

Reviewed By: Balandat

Differential Revision: D54280813

botorch/generation/gen.py

@@ -283,7 +283,9 @@ def f(x):
                 candidates = torch.from_numpy(x0).to(candidates).reshape(shapeX)
                 warnings.warn(
                     "SLSQP failed to converge to a solution the satisfies the "
-                    "non-linear constraints. Returning the feasible starting point."
+                    "non-linear constraints. Returning the feasible starting point.",
+                    OptimizationWarning,
+                    stacklevel=2,
                 )
                 break
 
@@ -462,6 +464,7 @@ def _process_scipy_result(res: OptimizeResult, options: Dict[str, Any]) -> None:
                 "Optimization failed within `scipy.optimize.minimize` with no "
                 "status returned to `res.`",
                 OptimizationWarning,
+                stacklevel=3,
             )
     elif not res.success:
         if (
@@ -486,16 +489,5 @@ def _process_scipy_result(res: OptimizeResult, options: Dict[str, Any]) -> None:
                     f"Optimization failed within `scipy.optimize.minimize` with status "
                     f"{res.status} and message {res.message}.",
                     OptimizationWarning,
+                    stacklevel=3,
                 )
-
-
-def minimize(*args, **kwargs):
-    """Deprecated, use `botorch.generation.gen.minimize_with_timeout`."""
-    # TODO: Reap this after the next stable Ax release.
-    warnings.warn(
-        "`botorch.generation.gen.minimize` is an alias for "
-        "`botorch.generation.gen.minimize_with_timeout` and will "
-        "be removed in a future release.",
-        DeprecationWarning,
-    )
-    return minimize_with_timeout(*args, **kwargs)

test/generation/test_gen.py

@@ -371,16 +371,3 @@ def test_random_restart_optimization(self):
                 batch_candidates=batch_candidates, batch_values=batch_acq_values
             )
             self.assertTrue(-EPS <= candidates <= 1 + EPS)
-
-
-class TestDeprecateMinimize(BotorchTestCase):
-    def test_deprecate_minimize(self):
-        from botorch.generation.gen import minimize
-
-        with self.assertWarnsRegex(
-            DeprecationWarning, "botorch.generation.gen.minimize_with_timeout"
-        ):
-            try:
-                minimize(None, None)
-            except Exception:
-                pass