Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.75.0 #22

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Rust 1.75.0 #22

merged 3 commits into from
Mar 15, 2024

Conversation

rubdos
Copy link
Contributor

@rubdos rubdos commented Dec 29, 2023

Based on #21, but doesn't compile at all yet.

Plan:

  • Make 1.73.0 compile (Rust 1.73.0 #21)
  • Rebase this on the 1.73 fix
  • Make 1.75 compile

It would be highly beneficial for Whisperfish to have 1.75, because I expect the Rust ecosystem to adapt the return position impl Trait in trait feature very rapidly.

Part of The Rust Plan

@rubdos rubdos marked this pull request as draft December 29, 2023 09:35
@rubdos rubdos mentioned this pull request Dec 29, 2023
@rubdos rubdos marked this pull request as ready for review December 29, 2023 13:30
@rubdos
Copy link
Contributor Author

rubdos commented Jan 3, 2024

To cite @direc85 in rubdos#1, the remaining issue can be resolved in the spec file:

As it turned out, the bug is fixable in environment (Whisperfish .spec in my use case) instead:

export TMPDIR=$(realpath "%{_sourcedir}/.tmp")
mkdir -p $TMPDIR

So, it's a bug somewhere in Scratchbox instead -- closing this PR as redundant (and potentially harmful).

@direc85
Copy link
Contributor

direc85 commented Feb 18, 2024

I'm afraid my patch has a few extra lines that should be removed. I'm afk currently, but I'll check and fix that late this evening.

Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks. Looks good and we got Gecko esr78 building against newer Rust as well. We'll do final verification still.

rust.changes Show resolved Hide resolved
rubdos and others added 2 commits March 15, 2024 10:56
This patch is needed because in sb2 the temp files written to /tmp
by rustc are no longer available when the linker tries to use them.
Work around the issue by setting $TMPDIR to $HOME/.tmp instead.
If $TMPDIR is already set, that value is used as expected.
@mlehtima mlehtima merged commit 8b93fea into sailfishos:master Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants