Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement login via browserid / mozilla persona #64

Closed
wants to merge 1 commit into from
Closed

implement login via browserid / mozilla persona #64

wants to merge 1 commit into from

Conversation

seafoodbuffet
Copy link
Contributor

Here's the PR related to #63

@sahat
Copy link
Owner

sahat commented Feb 9, 2014

If you can somehow add Mozilla Persona without modifying main.js - client-side JavaScript file, I will consider metging this PR.

After PR #59 there will be an object in secrets.js that let's you disable or enable authentication methods of your choice. I want Persona sign in to be optional as well.

@seafoodbuffet
Copy link
Contributor Author

Sure, a couple of options.

  1. I could either add a new js file public and have it be referenced as part of application.js
  2. I could insert script elements into only login and profile jade templates.

Do you have a preference?

@sahat
Copy link
Owner

sahat commented Feb 12, 2014

Please refer to Issue #63.

@sahat sahat closed this Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seafoodbuffet @sahat