Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres 14: EXTRACT returns a numeric, which is converted to a strin… #5825

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Apr 1, 2022

Description

  • see issue extract and postgresql 14 #5824
  • the conversion in postgres-blobs.coffee is not necessary, I don't see why. Must be related to rethinkdb.
  • the other client/server data serializations make sense. I've thought about this, and to me it makes sense to convert to a float (pg calls it "double precision") like before.

tests:

  • un-archiving a series of patches works fine
  • listings on the share server show timestamps when last edited
  • stopping idle projects … I just manually set the last edited field to something in the past and project stopped as expected

Checklist:

  • Testing instructions are provided, if not obvious
  • Release instructions are provided, if not obvious

…g. We force this to stay a double precision number (postgres 13) -- issue #5824
@williamstein
Copy link
Contributor

Very nice code!

@williamstein williamstein merged commit 7c751ca into master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants