Skip to content

refresh our Macaulay2 interface #40991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

refresh our Macaulay2 interface #40991

wants to merge 3 commits into from
+187 −230

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Oct 6, 2025 •
edited
Loading

so that

  • there is a global "optional macaulay2" doctest marker
  • almost all doctests pass, although there remains an issue about ChainComplex
  • conversion of polynomials uses a dict rather than a string
  • conversion of rationals use numerator / denominator rather than a string

Note that the conversion of ChainComplexes works, there is only a failure when running "sage -t"

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

Documentation preview for this PR (built with commit e6756ce; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rude...

src/sage/interfaces/macaulay2.py Outdated
n = ZZ(n)
if n.is_prime():
return GF(n)
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove else

src/sage/interfaces/macaulay2.py Outdated
if cls_str == "ZZ":
from sage.rings.integer_ring import ZZ
return ZZ(repr_str)
elif cls_str == "QQ":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if

@dcoudert
Copy link
Contributor

dcoudert commented Oct 8, 2025

lint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: interfaces: optional s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @dcoudert