Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix CI for #39363 #39373

Closed
wants to merge 7 commits into from
Closed

Conversation

user202729
Copy link
Contributor

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 marked this pull request as draft January 24, 2025 03:57
@user202729 user202729 mentioned this pull request Jan 24, 2025
1 task
Copy link

Documentation preview for this PR (built with commit 62c1b97; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Jan 24, 2025

Oh, I see! I overlooked that, rather weird to me, thing. I thought all such setup is done by git and git-related code.

@user202729
Copy link
Contributor Author

user202729 commented Jan 24, 2025

You can cherry-pick the commits on your pull request (or just make the change yourself), I suppose.

Maybe add this (or appropriate wording)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index bbecdf4..408b6c8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -308,6 +308,8 @@ jobs:
 
       - name: Generate Dockerfile
         # From docker.yml
+        # The `tox -e <environment name>` command runs a few commands in `tox.ini`,
+        # which includes `.ci/write-dockerfile.sh` to generate `Dockerfile`.
         run: |
           tox -e ${{ env.TOX_ENV }}
           cp .tox/${{ env.TOX_ENV }}/Dockerfile .

(thanks 😁 that probably took me an hour or two to find)

@user202729 user202729 closed this Jan 24, 2025
@dimpase
Copy link
Member

dimpase commented Jan 24, 2025

thanks, I cherry picked. A more githubby way would have been for you to open a PR to the branch of the patent PR in my fork. Then I could have just merged the branch here into my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants