-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fix CI for #39363 #39373
Test fix CI for #39363 #39373
Conversation
as autoconf's generated configure clobbers conftest*, we are saving conftest.py from it by making a backup copy and then restoring it after the real configure was run.
Documentation preview for this PR (built with commit 62c1b97; changes) is ready! 🎉 |
Oh, I see! I overlooked that, rather weird to me, thing. I thought all such setup is done by git and git-related code. |
You can cherry-pick the commits on your pull request (or just make the change yourself), I suppose. Maybe add this (or appropriate wording) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index bbecdf4..408b6c8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -308,6 +308,8 @@ jobs:
- name: Generate Dockerfile
# From docker.yml
+ # The `tox -e <environment name>` command runs a few commands in `tox.ini`,
+ # which includes `.ci/write-dockerfile.sh` to generate `Dockerfile`.
run: |
tox -e ${{ env.TOX_ENV }}
cp .tox/${{ env.TOX_ENV }}/Dockerfile . (thanks 😁 that probably took me an hour or two to find) |
thanks, I cherry picked. A more githubby way would have been for you to open a PR to the branch of the patent PR in my fork. Then I could have just merged the branch here into my fork. |
📝 Checklist
⌛ Dependencies