Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few fixes for ruff PLC #39337

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

this is about using .items() when possible

here in various folders

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

src/sage/interfaces/lie.py Outdated Show resolved Hide resolved
src/sage/knots/link.py Outdated Show resolved Hide resolved
src/sage/monoids/string_monoid_element.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 17, 2025

Documentation preview for this PR (built with commit f1927a4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

merci beaucoup David. Désolé de faire autant de tickets aussi triviaux..

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 19, 2025
this is about using `.items()` when possible

here in various folders

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#39337
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
@dcoudert
Copy link
Contributor

Pas de souci. Et si tu as du courage, il y a pas mal de tickets pas trop compliqués en attente sur les graphes.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 20, 2025
    
this is about using `.items()` when possible

here in various folders

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39337
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 23, 2025
    
this is about using `.items()` when possible

here in various folders

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39337
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 25, 2025
    
this is about using `.items()` when possible

here in various folders

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39337
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
@vbraun vbraun merged commit a4fb3b2 into sagemath:develop Jan 27, 2025
20 of 23 checks passed
@fchapoton fchapoton deleted the some_more_fixes_ruff_PLC branch January 27, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants