Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let the categories handle "is_commutative" for rings #39303

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

let the categories handle "is_commutative" for rings #39303

wants to merge 2 commits into from

Conversation

fchapoton
Copy link
Contributor

This makes sure that the method is_commutative for rings is handled by the category framework and not by the auld Ring class.

Also adding annotations on some is_commutative methods

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

Documentation preview for this PR (built with commit d373f69; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: needs review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fchapoton