minor annotation details in posets to please mypy #39252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit c63b0f1; changes) is ready! 🎉 |
dcoudert
reviewed
Jan 11, 2025
| x in orbits[orbit_number[dual_isomorphism[e]]]] | ||
|
|
||
| # Fix following after issue #20727 | ||
| comps = [[x for x in range(n) |
There was a problem hiding this comment.
Is it safe to change the order of the items in comps ?
There was a problem hiding this comment.
hmm, c'est vrai que c'est pas si clair...
There was a problem hiding this comment.
voila, ca doit etre mieux comme ca.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
typically avoiding type confusion
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#39252
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
typically avoiding type confusion
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#39252
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typically avoiding type confusion
📝 Checklist