Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional elliptic curve data from database_cremona_ellcurve #38917

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented Nov 3, 2024

If the optional db in istalled, then extra data is passed to the elliptic curve constructor. Recently unexpected keyword arguments were changed to an exception, without taking the optional package into account.

Caused by #38361

Without the patch tests fail with

$ sage -i database_cremona_ellcurve
$ sage -t src/sage/schemes/elliptic_curves/period_lattice.py
[...]
**********************************************************************
File "src/sage/schemes/elliptic_curves/period_lattice.py", line 77, in sage.schemes.elliptic_curves.period_lattice
Failed example:
    E = EllipticCurve('37a')
Exception raised:
    Traceback (most recent call last):
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py", line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py", line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.schemes.elliptic_curves.period_lattice[14]>", line 1, in <module>
        E = EllipticCurve('37a')
            ^^^^^^^^^^^^^^^^^^^^
      File "sage/structure/factory.pyx", line 373, in sage.structure.factory.UniqueFactory.__call__
        return self.get_object(version, key, kwds)
      File "sage/structure/factory.pyx", line 416, in sage.structure.factory.UniqueFactory.get_object
        obj = self.create_object(version, key, **extra_args)
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/elliptic_curves/constructor.py", line 508, in create_object
        return EllipticCurve_rational_field(x, **kwds)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/elliptic_curves/ell_rational_field.py", line 207, in __init__
        raise TypeError(f"unexpected keyword arguments: {kwds}")
    TypeError: unexpected keyword arguments: {'db_extra': [1, 5.98691729246392, 0.305999773834052, 0.0511114082399688, 1.0]}
**********************************************************************

If the optional db in istalled, then extra data is passed to the
elliptic curve constructor. Recently unexpected keyword arguments were
changed to an exception, without taking the optional package into
account.

Caused by sagemath#38361
Copy link

github-actions bot commented Nov 3, 2024

Documentation preview for this PR (built with commit e7327ec; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 8, 2024
sagemathgh-38917: Allow optional elliptic curve data from database_cremona_ellcurve
    
If the optional db in istalled, then extra data is passed to the
elliptic curve constructor. Recently unexpected keyword arguments were
changed to an exception, without taking the optional package into
account.

Caused by sagemath#38361

Without the patch tests fail with
```
$ sage -i database_cremona_ellcurve
$ sage -t src/sage/schemes/elliptic_curves/period_lattice.py
[...]
**********************************************************************
File "src/sage/schemes/elliptic_curves/period_lattice.py", line 77, in
sage.schemes.elliptic_curves.period_lattice
Failed example:
    E = EllipticCurve('37a')
Exception raised:
    Traceback (most recent call last):
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.schemes.elliptic_curves.period_lattice[14]>",
line 1, in <module>
        E = EllipticCurve('37a')
            ^^^^^^^^^^^^^^^^^^^^
      File "sage/structure/factory.pyx", line 373, in
sage.structure.factory.UniqueFactory.__call__
        return self.get_object(version, key, kwds)
      File "sage/structure/factory.pyx", line 416, in
sage.structure.factory.UniqueFactory.get_object
        obj = self.create_object(version, key, **extra_args)
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/constructor.py", line 508, in create_object
        return EllipticCurve_rational_field(x, **kwds)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/ell_rational_field.py", line 207, in __init__
        raise TypeError(f"unexpected keyword arguments: {kwds}")
    TypeError: unexpected keyword arguments: {'db_extra': [1,
5.98691729246392, 0.305999773834052, 0.0511114082399688, 1.0]}
**********************************************************************
```
    
URL: sagemath#38917
Reported by: Volker Braun
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 9, 2024
sagemathgh-38917: Allow optional elliptic curve data from database_cremona_ellcurve
    
If the optional db in istalled, then extra data is passed to the
elliptic curve constructor. Recently unexpected keyword arguments were
changed to an exception, without taking the optional package into
account.

Caused by sagemath#38361

Without the patch tests fail with
```
$ sage -i database_cremona_ellcurve
$ sage -t src/sage/schemes/elliptic_curves/period_lattice.py
[...]
**********************************************************************
File "src/sage/schemes/elliptic_curves/period_lattice.py", line 77, in
sage.schemes.elliptic_curves.period_lattice
Failed example:
    E = EllipticCurve('37a')
Exception raised:
    Traceback (most recent call last):
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.schemes.elliptic_curves.period_lattice[14]>",
line 1, in <module>
        E = EllipticCurve('37a')
            ^^^^^^^^^^^^^^^^^^^^
      File "sage/structure/factory.pyx", line 373, in
sage.structure.factory.UniqueFactory.__call__
        return self.get_object(version, key, kwds)
      File "sage/structure/factory.pyx", line 416, in
sage.structure.factory.UniqueFactory.get_object
        obj = self.create_object(version, key, **extra_args)
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/constructor.py", line 508, in create_object
        return EllipticCurve_rational_field(x, **kwds)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/ell_rational_field.py", line 207, in __init__
        raise TypeError(f"unexpected keyword arguments: {kwds}")
    TypeError: unexpected keyword arguments: {'db_extra': [1,
5.98691729246392, 0.305999773834052, 0.0511114082399688, 1.0]}
**********************************************************************
```
    
URL: sagemath#38917
Reported by: Volker Braun
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 13, 2024
sagemathgh-38917: Allow optional elliptic curve data from database_cremona_ellcurve
    
If the optional db in istalled, then extra data is passed to the
elliptic curve constructor. Recently unexpected keyword arguments were
changed to an exception, without taking the optional package into
account.

Caused by sagemath#38361

Without the patch tests fail with
```
$ sage -i database_cremona_ellcurve
$ sage -t src/sage/schemes/elliptic_curves/period_lattice.py
[...]
**********************************************************************
File "src/sage/schemes/elliptic_curves/period_lattice.py", line 77, in
sage.schemes.elliptic_curves.period_lattice
Failed example:
    E = EllipticCurve('37a')
Exception raised:
    Traceback (most recent call last):
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File
"/var/lib/buildbot/worker/sage_git/build/src/sage/doctest/forker.py",
line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.schemes.elliptic_curves.period_lattice[14]>",
line 1, in <module>
        E = EllipticCurve('37a')
            ^^^^^^^^^^^^^^^^^^^^
      File "sage/structure/factory.pyx", line 373, in
sage.structure.factory.UniqueFactory.__call__
        return self.get_object(version, key, kwds)
      File "sage/structure/factory.pyx", line 416, in
sage.structure.factory.UniqueFactory.get_object
        obj = self.create_object(version, key, **extra_args)
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/constructor.py", line 508, in create_object
        return EllipticCurve_rational_field(x, **kwds)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/var/lib/buildbot/worker/sage_git/build/src/sage/schemes/ell
iptic_curves/ell_rational_field.py", line 207, in __init__
        raise TypeError(f"unexpected keyword arguments: {kwds}")
    TypeError: unexpected keyword arguments: {'db_extra': [1,
5.98691729246392, 0.305999773834052, 0.0511114082399688, 1.0]}
**********************************************************************
```
    
URL: sagemath#38917
Reported by: Volker Braun
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit bbf4466 into sagemath:develop Nov 16, 2024
22 of 23 checks passed
@user202729 user202729 mentioned this pull request Feb 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants