-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format function headers around =
and ,
#38907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f0b245
to
cb41666
Compare
cb41666
to
9eb5edf
Compare
Documentation preview for this PR (built with commit 2c21f54; changes) is ready! 🎉 |
mantepse
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Not Now, When?
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 5, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 6, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 7, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 13, 2024
sagemathgh-38907: Format function headers around `=` and `,` A PEP8 sweep mostly of function headers around equal signs and commas. An illustration of the type of changes: From ``` def f(x = 0,y): ``` to ``` def f(x=0, y): ``` I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those. URL: sagemath#38907 Reported by: gmou3 Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PEP8 sweep mostly of function headers around equal signs and commas.
An illustration of the type of changes:
From
to
I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those.