Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format function headers around = and , #38907

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Nov 2, 2024

A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From

def f(x = 0,y):

to

def f(x=0, y):

I am in the awkward position of announcing the abundance of such PEP8-malformations, thousands of which remain in functions calls. I may do a follow-up PR addressing those.

@gmou3 gmou3 force-pushed the format_headers_around_equals branch from 7f0b245 to cb41666 Compare November 2, 2024 17:29
@gmou3 gmou3 force-pushed the format_headers_around_equals branch from cb41666 to 9eb5edf Compare November 2, 2024 17:37
Copy link

github-actions bot commented Nov 2, 2024

Documentation preview for this PR (built with commit 2c21f54; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Not Now, When?

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 5, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 6, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 7, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 8, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 9, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 13, 2024
sagemathgh-38907: Format function headers around `=` and `,`
    
A PEP8 sweep mostly of function headers around equal signs and commas.

An illustration of the type of changes:
From
```
def f(x = 0,y):
```
to
```
def f(x=0, y):
```

I am in the awkward position of announcing the abundance of such
PEP8-malformations, thousands of which remain in functions calls. I may
do a follow-up PR addressing those.
    
URL: sagemath#38907
Reported by: gmou3
Reviewer(s): Martin Rubey
@vbraun vbraun merged commit 813f2b5 into sagemath:develop Nov 16, 2024
22 of 24 checks passed
@gmou3 gmou3 deleted the format_headers_around_equals branch November 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants