add "# long time" to slow-ish composite isogeny doctest #38901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
added
t: enhancement
p: trivial / 5
t: tests
c: elliptic curves
c: algebra
s: needs review
and removed
s: needs review
c: algebra
labels
|
Documentation preview for this PR (built with commit 27343d9; changes) is ready! 🎉 |
|
Thanks, this takes about 30s on my machine. The warnings aren't new but the threshold has been lowered and the "how long did it take" computation is much more reliable now. |
yyyyx4
deleted the
public/mark_slowish_composite_isogeny_doctest_as_long
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to silence the new(?) warning about tests that take a long time.