-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out R warnings #38294
Merged
Merged
Filter out R warnings #38294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are causing some doctest failures after sagemath#35396
mkoeppe
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Merge conflict |
github-actions
bot
added
s: needs review
and removed
s: positive review
s: needs work
labels
Jul 10, 2024
Simple merge |
Documentation preview for this PR (built with commit 23497d0; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 13, 2024
These are causing some doctest failures after sagemath#35396 ``` ********************************************************************** File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 51, in sage.interfaces.r Failed example: v = 2*x+y+1; v Expected: [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5 Got: R[write to console]: Además: R[write to console]: Aviso: <BLANKLINE> R[write to console]: In sage10 + sage6 : R[write to console]: <BLANKLINE> R[write to console]: longitud de objeto mayor no es múltiplo de la longitud de uno menor <BLANKLINE> [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5 ********************************************************************** File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 78, in sage.interfaces.r Failed example: r(-17).sqrt() Expected: [1] NaN Got: R[write to console]: Además: R[write to console]: Aviso: <BLANKLINE> R[write to console]: In sqrt(sage10) : R[write to console]: Se han producido NaNs <BLANKLINE> [1] NaN ********************************************************************** File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 356, in sage.interfaces.r._setup_r_to_sage_converter Failed example: r(-17).sqrt().sage() Expected: nan Got: R[write to console]: Además: R[write to console]: Aviso: <BLANKLINE> R[write to console]: In sqrt(sage4) : R[write to console]: Se han producido NaNs <BLANKLINE> nan ********************************************************************** ``` URL: sagemath#38294 Reported by: Antonio Rojas Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are causing some doctest failures after #35396