Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.schemes: Modularization fixes (imports) #38142

Merged
merged 11 commits into from
Jul 24, 2024
Merged

sage.schemes: Modularization fixes (imports) #38142

merged 11 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 3, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 13bc753; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 3, 2024

Otherwise lgtm.

kwankyu
kwankyu approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2024

Thank you!

@mkoeppe mkoeppe force-pushed the sage_schemes_imports branch from f52c4fe to b71511d Compare June 9, 2024 17:36
@mkoeppe mkoeppe force-pushed the sage_schemes_imports branch from b71511d to dc35e84 Compare June 22, 2024 20:06
@vbraun vbraun merged commit 017f2ce into sagemath:develop Jul 24, 2024
18 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the sage_schemes_imports branch July 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: algebraic geometry t: refactoring v: large
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun