-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exceptiongroup
, importlib_metadata
, importlib_resources
, typing_extensions
: Require 3.12 features
#37402
base: develop
Are you sure you want to change the base?
Conversation
Since Gentoo doesn't have an importlib_metadata package, I really don't want to have to install importlib_metadata "just in case." |
Could you explain how this PR changes anything regarding this? |
Before I needed python-3.11 to skip the package that does nothing, but now I need python-3.12 to skip it. |
Is this not correct? |
Oh, yeah. It's the other one. We don't have importlib-resources any more since https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef0ca954c |
|
Well, this removal may have been a mistake... |
It's almost like encoding the same information in two places is prone to failure :P |
Which two places? |
gentoo.git and sage.git |
Oh, OK. Well, as you know, we have this information system for users and to provision the testing environment, and both is done in a way that is robust to inaccuracies. |
Is this a packaging concern, or about what you have on your machine? |
Little of both. When doing sage development, I shouldn't have to install these as SPKGs -- that's one part of it. For distribution packaging they're either superfluous or problematic. Right now they're superfluous. But if someone actually uses a python-3.12 feature from importlib-resources, then not having it would be problematic. |
c2ef586
to
1f8f411
Compare
29b42a1
to
bb3dcc2
Compare
The spam bot just pinged me on this! I fail to understand your motivation. What feature of python 3.12 is so important that you need to do this? It seems much more reasonable to drop the packages altogether and avoid features not available in the range of supported python (3.9 - 3.12). Can you make a list of the features you would like to have available that are not available on 3.9? Note that 3.9 is already outside the NEP range (42 months) so it wouldn't be such a shame to drop it if there is a strong reason. |
Why would you say that? |
Can you make a list of the features you would like to have available that are not available on 3.9? |
bb3dcc2
to
46077c5
Compare
Can you make a list of the features you would like to have available that are not available on python 3.9? |
Documentation preview for this PR (built with commit 46077c5; changes) is ready! 🎉 |
📝 Checklist
We tighten the lower bounds of these backport packages in install-requires so that the features of Python 3.12 can be used.
Also some updates to latest.
⌛ Dependencies
build/pkgs/setuptools_scm
: Upgrade to 8.1.0, fix dependency typing_extensions, change some packages towheel
#38226