Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceptiongroup, importlib_metadata, importlib_resources, typing_extensions: Require 3.12 features #37402

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 20, 2024

📝 Checklist

We tighten the lower bounds of these backport packages in install-requires so that the features of Python 3.12 can be used.

Also some updates to latest.

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@orlitzky
Copy link
Contributor

Since Gentoo doesn't have an importlib_metadata package, I really don't want to have to install importlib_metadata "just in case."

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

Could you explain how this PR changes anything regarding this?

@orlitzky
Copy link
Contributor

Before I needed python-3.11 to skip the package that does nothing, but now I need python-3.12 to skip it.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

$ cat build/pkgs/importlib_metadata/distros/gentoo.txt
dev-python/importlib_metadata

Is this not correct?

@orlitzky
Copy link
Contributor

$ cat build/pkgs/importlib_metadata/distros/gentoo.txt
dev-python/importlib_metadata

Is this not correct?

Oh, yeah. It's the other one. We don't have importlib-resources any more since https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef0ca954c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

$ cat build/pkgs/importlib_resources/distros/gentoo.txt
dev-python/importlib_resources

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

We don't have importlib-resources any more since https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef0ca954c

Well, this removal may have been a mistake...

@orlitzky
Copy link
Contributor

$ cat build/pkgs/importlib_resources/distros/gentoo.txt
dev-python/importlib_resources

It's almost like encoding the same information in two places is prone to failure :P

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

Which two places?

@orlitzky
Copy link
Contributor

gentoo.git and sage.git

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

Oh, OK. Well, as you know, we have this information system for users and to provision the testing environment, and both is done in a way that is robust to inaccuracies.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

Before I needed python-3.11 to skip the package that does nothing, but now I need python-3.12 to skip it.

Is this a packaging concern, or about what you have on your machine?

@orlitzky
Copy link
Contributor

Before I needed python-3.11 to skip the package that does nothing, but now I need python-3.12 to skip it.

Is this a packaging concern, or about what you have on your machine?

Little of both. When doing sage development, I shouldn't have to install these as SPKGs -- that's one part of it.

For distribution packaging they're either superfluous or problematic. Right now they're superfluous. But if someone actually uses a python-3.12 feature from importlib-resources, then not having it would be problematic.

@mkoeppe mkoeppe force-pushed the backport_upgrades_3.12 branch from c2ef586 to 1f8f411 Compare February 25, 2024 17:36
@mkoeppe mkoeppe force-pushed the backport_upgrades_3.12 branch 2 times, most recently from 29b42a1 to bb3dcc2 Compare April 1, 2024 00:44
@tornaria
Copy link
Contributor

tornaria commented Apr 3, 2024

The spam bot just pinged me on this!

I fail to understand your motivation. What feature of python 3.12 is so important that you need to do this?

It seems much more reasonable to drop the packages altogether and avoid features not available in the range of supported python (3.9 - 3.12).

Can you make a list of the features you would like to have available that are not available on 3.9? Note that 3.9 is already outside the NEP range (42 months) so it wouldn't be such a shame to drop it if there is a strong reason.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 3, 2024

It seems much more reasonable

Why would you say that?

@tornaria
Copy link
Contributor

tornaria commented Apr 3, 2024

It seems much more reasonable

Why would you say that?

Can you make a list of the features you would like to have available that are not available on 3.9?

@mkoeppe mkoeppe force-pushed the backport_upgrades_3.12 branch from bb3dcc2 to 46077c5 Compare April 9, 2024 02:11
@tornaria
Copy link
Contributor

tornaria commented Apr 9, 2024

Can you make a list of the features you would like to have available that are not available on python 3.9?

Copy link

github-actions bot commented Apr 9, 2024

Documentation preview for this PR (built with commit 46077c5; changes) is ready! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants