Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage_docbuild: add needs sphinx tags #37269

Merged
merged 1 commit into from
Feb 13, 2024
Merged

sage_docbuild: add needs sphinx tags #37269

merged 1 commit into from
Feb 13, 2024

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Feb 9, 2024

Add "needs sphinx" tags to some tests in src/sage_docbuild so there
is no failure when sphinx is not installed in the system.

See: #37263 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

@tornaria tornaria requested a review from mkoeppe February 9, 2024 15:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Documentation preview for this PR (built with commit 1b0ab3d; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2024

Who's doctesting src/sage_docbuild when sage-docbuild is not installed and why? sphinx is a dependency (install-requires) of sage-docbuild

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2024 •
edited
Loading

But it does not hurt to add such # needs tags, so positive review.

@tornaria
Copy link
Contributor Author

tornaria commented Feb 9, 2024

Who's doctesting src/sage_docbuild when sage-docbuild is not installed and why? sphinx is a dependency (install-requires) of sage-docbuild

./sage -t --all, as explained in #37263 (comment), when using --disable-doc --enable-editable

@vbraun vbraun merged commit d3deb28 into sagemath:develop Feb 13, 2024
21 checks passed
@tornaria tornaria deleted the needs_sphinx branch February 16, 2024 19:13
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe Awaiting requested review from mkoeppe

Assignees
No one assigned
Labels
p: critical / 2
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tornaria @mkoeppe @vbraun