build/pkgs/sympy: Upgrade to 1.13.2
#36641
Merged
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shows the expected test failures: These tests are expected to fail with SymPy 1.12 but should pass with SymPy's master branch. |
|
I have made SymPy's Sage CI job point to this PR: sympy/sympy#25867 The SymPy CI job has passed: Anyone wanting to check this in future can look at the status of CI on the SymPy master branch:
|
|
Our PDF docbuild does not like the printing change using "↪" (which you mentioned in https://groups.google.com/g/sage-devel/c/fOTkNoU02Oo/m/j116LUouBwAJ) |
|
The changes here seem to have caused the SymPy CI job to fail because the sage build now expects git to be installed: I am a bit confused about exactly which version of sympy would be used in the sympy CI job if the build is attempting to install sympy from the master branch (rather than the sympy commit that triggers the CI job). |
|
@oscarbenjamin Thanks for reporting this. I've pushed a fix |
|
Documentation preview for this PR (built with commit 6fb81c3; changes) is ready! 🎉 |
|
The git problem still seems to be happening: |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
…fferent source type, clean up
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
For example, when switching from a `pip` package to `wheel` package,
remove the `requirements.txt` file.
When switching from `normal` to `wheel`, remove the `spkg-install.in`
file.
One of these cases was handled by a commit on sagemath#36641, cherry-picked from
there.
Generalizing here to avoid mistakes such as
sagemath#37129 (comment) in
the future.
Example:
```
$ ./sage -package create imagesize --pypi
Downloading tarball from https://pypi.io/packages/py2.py3/i/imagesize/im
agesize-1.4.1-py2.py3-none-any.whl to /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/upstream/imagesize-1.4.1-py2.py3-none-any.whl
[......................................................................]
$ git status
On branch sage_package_create_remove_files
Your branch is ahead of 'upstream/develop' by 3 commits.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: build/pkgs/imagesize/SPKG.rst
modified: build/pkgs/imagesize/checksums.ini
modified: build/pkgs/imagesize/install-requires.txt
deleted: build/pkgs/imagesize/spkg-install.in
modified: build/pkgs/imagesize/type
```
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#37352
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
…fferent source type, clean up
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
For example, when switching from a `pip` package to `wheel` package,
remove the `requirements.txt` file.
When switching from `normal` to `wheel`, remove the `spkg-install.in`
file.
One of these cases was handled by a commit on sagemath#36641, cherry-picked from
there.
Generalizing here to avoid mistakes such as
sagemath#37129 (comment) in
the future.
Example:
```
$ ./sage -package create imagesize --pypi
Downloading tarball from https://pypi.io/packages/py2.py3/i/imagesize/im
agesize-1.4.1-py2.py3-none-any.whl to /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/upstream/imagesize-1.4.1-py2.py3-none-any.whl
[......................................................................]
$ git status
On branch sage_package_create_remove_files
Your branch is ahead of 'upstream/develop' by 3 commits.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: build/pkgs/imagesize/SPKG.rst
modified: build/pkgs/imagesize/checksums.ini
modified: build/pkgs/imagesize/install-requires.txt
deleted: build/pkgs/imagesize/spkg-install.in
modified: build/pkgs/imagesize/type
```
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#37352
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 22, 2024
…fferent source type, clean up
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
For example, when switching from a `pip` package to `wheel` package,
remove the `requirements.txt` file.
When switching from `normal` to `wheel`, remove the `spkg-install.in`
file.
One of these cases was handled by a commit on sagemath#36641, cherry-picked from
there.
Generalizing here to avoid mistakes such as
sagemath#37129 (comment) in
the future.
Example:
```
$ ./sage -package create imagesize --pypi
Downloading tarball from https://pypi.io/packages/py2.py3/i/imagesize/im
agesize-1.4.1-py2.py3-none-any.whl to /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/upstream/imagesize-1.4.1-py2.py3-none-any.whl
[......................................................................]
$ git status
On branch sage_package_create_remove_files
Your branch is ahead of 'upstream/develop' by 3 commits.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: build/pkgs/imagesize/SPKG.rst
modified: build/pkgs/imagesize/checksums.ini
modified: build/pkgs/imagesize/install-requires.txt
deleted: build/pkgs/imagesize/spkg-install.in
modified: build/pkgs/imagesize/type
```
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#37352
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 8, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> [python-flint](https://github.com/flintlib/python-flint) is an optional dependency of the upcoming SymPy 1.13 (https://groups.google.com/g/sympy/c/S3LL7hYvD_A) @oscarbenjamin See also - sagemath#36641 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#37222 - Depends on sagemath#36999 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37224 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
oscarbenjamin
force-pushed
the
pr_doctests_sympy_1.13
branch
from
7ed1193 to
b5bd7e1
Compare
oscarbenjamin
commented
Jul 17, 2024
build/pkgs/sympy/package-version.txt
Outdated
| @@ -1 +1 @@ | |||
| 1.12.1 | |||
| 1.13.0 | |||
There was a problem hiding this comment.
I am assuming that this is what it should be set to now...
There is likely to be a 1.13.1 release coming very soon.
1 task
|
Works fine for me. |
|
It cannot be merged in this form (as it changes the package type for testing purposes); it needs to wait for the actual release. |
Yes, that's why I gave positive review. But it's much better if you can also review since I only tested sagelib. Edit: thanks. |
|
conda tests fail because sympy is pinned to |
|
I've just pushed SymPy 1.13.1 to PyPI: https://pypi.org/project/sympy/ I am not sure when it will appear in conda forge (I don't manage that): |
mkoeppe
force-pushed
the
pr_doctests_sympy_1.13
branch
from
ab3bf55 to
a9f0445
Compare
mkoeppe
changed the title
build/pkgs/sympy: Upgrade to 1.13build/pkgs/sympy: Upgrade to 1.13.1
mkoeppe
force-pushed
the
pr_doctests_sympy_1.13
branch
from
a9f0445 to
2e78781
Compare
mkoeppe
force-pushed
the
pr_doctests_sympy_1.13
branch
from
b87cc18 to
9e8ab0b
Compare
I've now pushed 1.13.2 to PyPI. The conda package update is ready but someone needs to merge it: |
mkoeppe
changed the title
build/pkgs/sympy: Upgrade to 1.13.1build/pkgs/sympy: Upgrade to 1.13.2
mkoeppe
force-pushed
the
pr_doctests_sympy_1.13
branch
from
b095eba to
6fb81c3
Compare
|
I've backed out the attempted update of our conda-lock files from the branch -- other breakage stops the CI Conda from working anyway |
Is this a Sage CI problem or do you mean that there is an issue with the SymPy Conda package? |
|
unrelated to SymPy |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 27, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> See https://groups.google.com/g/sage-devel/c/fOTkNoU02Oo/m/j116LUouBwAJ This upgrade includes doctest changes needed for compatibility with SymPy 1.13. This PR is also used by SymPy CI to keep track of compatibility between SymPy and Sage: https://github.com/sympy/sympy/blob/master/.github/workflows/ci-sage.yml https://github.com/sympy/sympy/actions/runs/6724078875/job/18275557828 URL: sagemath#36641 Reported by: Oscar Benjamin Reviewer(s): Oscar Benjamin
|
Thanks everyone! |
|
With this PR the conda ci fails now: (seen also in the ci of this PR) Could you please provide a follow-up PR (e.g. by accepting the results of both versions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://groups.google.com/g/sage-devel/c/fOTkNoU02Oo/m/j116LUouBwAJ
This upgrade includes doctest changes needed for compatibility with SymPy 1.13.
This PR is also used by SymPy CI to keep track of compatibility between SymPy and Sage:
https://github.com/sympy/sympy/blob/master/.github/workflows/ci-sage.yml
https://github.com/sympy/sympy/actions/runs/6724078875/job/18275557828