Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fplll 5.4.5, fpylll 0.6 #36477

Merged
merged 5 commits into from
Nov 5, 2023
Merged

fplll 5.4.5, fpylll 0.6 #36477

merged 5 commits into from
Nov 5, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 18, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 19, 2023

  • The packages are unconstrained in our conda.txt.
  • The packages currently have the strict pins in spkg-configure.m4 / install-requires.txt.

It's beyond the scope of the PR to change any of this. It is an upgrade ticket for Cython 3 and Python 3.12.

@tobiasdiez
Copy link
Contributor

That the current practice is not working is shown by the fact that the conda workflow is currently failing because of it. But, okay, I've opened #36482 if fixing it is out of the scope of this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2023

@mkoeppe mkoeppe requested review from dimpase and tornaria October 25, 2023 20:57
@tornaria
Copy link
Contributor

FWIW in void linux we are on fplll-5.4.5 and fpylll-0.6.0 (both unpatched). No issue at all with sagemath so it seems an easy upgrade.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 28, 2023

Let's get it in please.

@dimpase
Copy link
Member

dimpase commented Oct 28, 2023

seems that we really need a way to limit (or perhaps explicitly specify) the range of Sage mirrors - errors are due to a .cn mirror just hanging.

Once this is in, we can use it throughout CI to prevent this sort of trouble.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 28, 2023

Yes, that's #34411

@github-actions
Copy link

Documentation preview for this PR (built with commit a3b2f9b; changes) is ready! 🎉

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbraun vbraun merged commit 41625b8 into sagemath:develop Nov 5, 2023
22 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants