Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towards allowing to merge polynomials rings #36138

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

The aim would be to allow adding elements of polynomials rings with different variables.

For instance

sage: x,y=PolynomialRing(ZZ,'x,y').gens()
sage: u,v=PolynomialRing(ZZ,'u,v').gens()
sage: z=polygen(QQbar,'z')
sage: t=PolynomialRing(QQ,'t').gen()
sage: x+u
u + x
sage: x+z
z + x
sage: t+z
z + t
sage: t+x
x + t

This is done by refactoring the merge and __mul__ methods in PolynomialFunctor and MultiPolynomialFunctor

This seems to have side effects on the infinite polynomial rings.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton
Copy link
Contributor Author

87 related failing doctests, but most are improvements (success replacing failure)

Copy link

github-actions bot commented Mar 5, 2024

Documentation preview for this PR (built with commit 4e19927; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant