Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gap: use GAP_NewPlist with a size hint #35878

Closed
wants to merge 6 commits into from
Closed

gap: use GAP_NewPlist with a size hint #35878

wants to merge 6 commits into from

Conversation

fingolfin
Copy link
Contributor

Extracted from PR #35862, which produces crashes; this should narrow down where the problem is.

@fchapoton
Copy link
Contributor

sage_list can be an iterable, not knowing its length

        cdef Obj l = GAP_NewPlist(len(sage_list))
    TypeError: object of type 'map' has no len()

@fingolfin
Copy link
Contributor Author

OK. That's just an optimization, can be dropped, then it'll be as bad/good as before.

@github-actions
Copy link

Documentation preview for this PR (built with commit dffb284; changes) is ready! 🎉

@fingolfin
Copy link
Contributor Author

I think I got this PR and subsequently #35862 to work, so I am closing this as it is again a "subset" of #35862.

@fingolfin fingolfin closed this Jul 27, 2023
@fingolfin fingolfin deleted the mh/NewPlist branch July 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @fchapoton