Extend MAX_MODULUS of matrix_modn_dense_double.pyx
#35855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vneiger
suggested changes
Jun 29, 2023
src/sage/matrix/matrix_space.py
Outdated
| @@ -617,7 +617,8 @@ def __init__(self, base_ring, nrows, ncols, sparse, implementation): | |||
|
|
|||
| - ``linbox-float`` - for integer mod rings up to `2^8 = 256` | |||
|
|
|||
| - ``linbox-double`` - for integer mod rings up to `2^23 = 8388608` | |||
| - ``linbox-double`` - for integer mod rings up to | |||
There was a problem hiding this comment.
There is trailing whitespace here
src/sage/matrix/matrix_space.py
Outdated
| @@ -617,7 +617,8 @@ def __init__(self, base_ring, nrows, ncols, sparse, implementation): | |||
|
|
|||
| - ``linbox-float`` - for integer mod rings up to `2^8 = 256` | |||
|
|
|||
| - ``linbox-double`` - for integer mod rings up to `2^23 = 8388608` | |||
| - ``linbox-double`` - for integer mod rings up to | |||
| `floor(2^26*sqrt(2) + 1/2) = 94906266` | |||
There was a problem hiding this comment.
And trailing whitespace here as well
|
Documentation preview for this PR (built with commit 413f251; changes) is ready! 🎉 |
|
Looks good to me |
vneiger
added
s: positive review
s: needs work
and removed
s: needs work
s: positive review
labels
|
The prime returned by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Assign to
MAX_MODULUSofmatrix_modn_dense_double.pyxthe actual limit for LinBoxModular<double>(Givaro'smaxCardinality)It allows better speed performances for matrices over the integers mod N, for N having 24 to 27 bits.
Fixes #35806
📝 Checklist
⌛ Dependencies