-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the KnotInfo interface to new Khovanov polynomial data (merged) #35800
Conversation
c32a834
to
9874e64
Compare
I don't know why all GitHub bots except the one building the documentation have been cancelled? Anyway, the changes of the branch do only effect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few very minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
Thank you, as well! |
@vbraun: strangely this PR is still open. |
Merge conflict |
@vbraun there is some mystery with this PR. It is already merged into Now, if I merge this branch with Note my review comment: #35800 (comment): With the missing commit there has been something irregular from the beginning: It was not visible on the |
Documentation preview for this PR (built with commit ab0a42e; changes) is ready! 🎉 |
CAUTION
Although this PR is not marked as merged it has been merged into 10.1.beta6
Note, that
Files changed 0
! For more information see #35800 (comment).📚 Description
A note in the current Khovanov polynomial method of the KnotInfo interface says:
The goal of this PR is the announced adaptation. Accordingly the PR lets Sage point to the current version 2023.6.1 of the Python wrapper of the database which contains the new columns.
📝 Checklist
⌛ Dependencies