Correct spelling in permgroup_named: Diyclic => Dicyclic

[dwbump]

📚 Description

DiCyclic groups are defined in permgroups_named.py. In 3 places it is misspelled. This PR corrects the misspelling.

(I think the preferred spelling would be Dicyclic, not DiCyclic, but this PR does not change that.)

📝 Checklist

• [x ] The title is concise, informative, and self-explanatory.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• [x ] I have updated the documentation accordingly.

⌛ Dependencies

[mkoeppe]

There's another instance in src/sage/algebras/fusion_rings/fusion_double.py

[kwankyu]

I think the preferred spelling would be Dicyclic, not DiCyclic, but this PR does not change that.

Why not? Actually "DiCyclic" has missing "c", but is in wrong capitalization.

[dwbump]

I think the preferred spelling would be Dicyclic, not DiCyclic, but this PR does not change that.

Why not? Actually "DiCyclic" has missing "c", but is in wrong capitalization.

I wouldn't capitalize the "c" and I would recommend changing it, but all this PR does is correct an obvious typo.

According to git blame, the lines containing the string "DiCyclic" are authored by Rob Beezer. I'm not sure if he is available as a reviewer.

[kwankyu]

Do you mean "DiCyclic" in class name? It is right in class name. I meant in normal text.

[dwbump]

Do you mean "DiCyclic" in class name? It is right in class name. I meant in normal text.

It is only used as a class name. But why is this correct?

There is another class called SemidihedralGroup. If DiCyclic is correct, why isn't that SemiDihedralGroup?

[kwankyu]

Do you mean "DiCyclic" in class name? It is right in class name. I meant in normal text.

It is only used as a class name. But why is this correct?

There is another class called SemidihedralGroup. If DiCyclic is correct, why isn't that SemiDihedralGroup?

You are right that the capitalization styles are not consistent. No one bothered to make them so.

[kwankyu]

... but all this PR does is correct an obvious typo.

But you introduced wrong capitalization in normal text. This is not acceptable.

According to git blame, the lines containing the string "DiCyclic" are authored by Rob Beezer. I'm not sure if he is available as a reviewer.

Perhaps not.

[dwbump]

... but all this PR does is correct an obvious typo.

But you introduced wrong capitalization in normal text. This is not acceptable.

I agree and I changed it in commit 4f47156.

[github-actions]

Documentation preview for this PR (built with commit 4f47156) is ready! 🎉

[kwankyu]

Thanks.

[kwankyu]

Please edit the PR title too.