-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove obsolete .zenodo.json* files, update CITATION.cff to fix zenodo/DOI #35666
Conversation
perhaps the version in CITATION.cff should be the upcoming version 10.1, not the current one. |
perhaps we should generate |
|
sorry, wrong click, now undone. Yes, I would say creating the .cff file in the script would be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge conflict |
I've rebased on top of 10.1.beta1. |
@vbraun - Please merge this manually, if needed. The conflict you got is due to An alternative is to split this into 2 PRs - the fist one removing automatic generation of |
This breaks the tarball creation script
|
oops,
should be SAGE_ROOT, not SAGE_SRC |
@vbraun - should be fixed now. |
Merge conflict |
the latter overrides the former, cf citation-file-format/citation-file-format#374 This will fix sagemath#35659
@vbraun - rebased again. Please merge manually, cf #35666 (comment) |
Documentation preview for this PR (built with commit 532b0de) is ready! 🎉 |
this is a leftover from sagemath#35666 which was somehow created during a messy manual merge.
this is a leftover from sagemath#35666 which was somehow created during a messy manual merge. This hopefully finally will unbreak our Zenodo integration URL: sagemath#36132 Reported by: Dima Pasechnik Reviewer(s): Matthias Köppe
Our DOI creation/update via zenodo is broken again.
CITATION.cff
overrides.zenodo.json
, cf.citation-file-format/citation-file-format#374
This will fix #35659