Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused by cached representation in cohomology classes #35650

Merged
merged 4 commits into from
Jun 3, 2023

Conversation

miguelmarco
Copy link
Contributor

@miguelmarco miguelmarco commented May 18, 2023

📚 Description

Fixes #35649

Adds the parent to the creation of cohomology classes, so they are not confused between different parents.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@miguelmarco
Copy link
Contributor Author

Should the issue be changed to positive review too?

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2023

No need for a status label on the issue; I've removed it.
It will be closed as completed automatically when the PR is merged.

@tscrim
Copy link
Collaborator

tscrim commented May 18, 2023

Minor point, but I don't think we should call the input parent as it is not the parent (which would be the not-(yet-)coded cohomology ring). Instead it should be something like cdga. That way it will also be future compatible.

Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@github-actions
Copy link

Documentation preview for this PR (built with commit b3d322e) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@vbraun vbraun merged commit d15771f into sagemath:develop Jun 3, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 3, 2023
@dimpase
Copy link
Member

dimpase commented Jun 4, 2023

b3d322e
added extra trailing space - how didn't you see this on the linters?

@dimpase
Copy link
Member

dimpase commented Jun 4, 2023

Perhaps the linter only shows the 1st trailing whitespace it finds, and so it didn't show this changed file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimal_model of GradedCommutativeAlgebra misuses cache
5 participants