-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tag fetching in docker workflow #35417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, as @dimpase confirms in #35571 (comment)
The "fetch tags" does still have a function, namely to make "git describe" more expressive. But let's get rid of this step at least for now. Thanks
Thanks for the review. The workflow is still broken btw in forks. The docker upload/download doesn't work, so the next level breaks, e.g. https://github.com/tobiasdiez/sage/actions/runs/4586981626/jobs/8106335802 |
For that failure, see the corresponding
|
We discussed this in #35108 (comment), I'll have to get back to it |
📚 Description
It fails in forks (e.g. https://github.com/tobiasdiez/sage/actions/runs/4586854543/jobs/8100123316) and shouldn't be necessary since the tag will be passed anyway via
EXTRA_DOCKER_TAGS
.📝 Checklist
⌛ Dependencies