-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate codecov reports even if other checks are failing #35412
Conversation
According to https://docs.codecov.com/docs/codecovyml-reference#codecovrequire_ci_to_pass, the value is |
But https://docs.codecov.com/docs/common-recipe-list#see-coverage-on-ci-test-failures has it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Let's deploy and see.
It is still not work @kwankyu how did you activate codecov in your fork? Is it still working there? |
Thanks @kwankyu for testing. I just noticed that after re-installing the codecov app here on github, everything is working fine. Sorry for the noise ;-) |
Okay. Thanks for taking care of this. I am happy with codecov checks. |
📚 Description
Follow-up from #35056. Currently no codecov reports are displayed because the doc deployment workflow is failing and codecov by default only adds its checks if all other checks are passing. We change this setting so that codecov checks are always added, regardless of other failing tests.
📝 Checklist
⌛ Dependencies