Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sagemath-standard through sagemath-{categories,environment,repl} #35143

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 15, 2023

📚 Description

Fixes #34587

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 15, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 15, 2023

[sagemath_environment-10.0.beta0] Successfully built sagemath-environment-10.0b0.tar.gz and sagemath_environment-10.0b0-py3-none-any.whl
[sagemath_environment-10.0.beta0] WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
[sagemath_environment-10.0.beta0] WARNING: Skipping sagemath_environment as it is not installed.
[sagemath_environment-10.0.beta0] ls: cannot access 'Using pip 22.3.1 from /sage/local/var/lib/sage/venv-python3.8/lib/python3.8/site-packages/pip (python 3.8)'$'\n''Looking in links: /sage/local/var/lib/sage/venv-python3.8/var/lib/sage/wheels'$'\n''Processing /sage/local/var/lib/sage/venv-python3.8/var/lib/sage/wheels/sagemath_environment-10.0b0-py3-none-any.whl'$'\n''Installing collected packages: sagemath-environment'$'\n''Successfully installed sagemath-environment-10.0b0'$'\n''/sage/local/var/lib/sage/venv-python3.8/var/lib/sage/wheels/sagemath_environment-10.0b0-py3-none-any.whl': No such file or directory
[sagemath_environment-10.0.beta0] using tox.ini: /__w/sage/sage/pkgs/sagemath-environment/tox.ini (pid 25775)
[sagemath_environment-10.0.beta0] using tox-3.27.0 from /sage/local/var/lib/sage/venv-python3.8/lib/python3.8/site-packages/tox/__init__.py (pid 25775)
[sagemath_environment-10.0.beta0] Traceback (most recent call last):
[sagemath_environment-10.0.beta0]   File "/sage/local/var/lib/sage/venv-python3.8/lib/python3.8/site-packages/py/_error.py", line 66, in checked_call
[sagemath_environment-10.0.beta0]     return func(*args, **kwargs)
[sagemath_environment-10.0.beta0] FileNotFoundError: [Errno 2] No such file or directory: '/__w/sage/sage/pkgs/sagemath-environment/Using'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 15, 2023

[sagemath_objects-10.0.beta0] Processing /sage/local/var/lib/sage/venv-python3.8/var/lib/sage/wheels/Cython-0.29.32-cp38-cp38-linux_x86_64.whl
[sagemath_objects-10.0.beta0] ERROR: Could not find a version that satisfies the requirement sage-setup~=10.0b0 (from versions: none)
[sagemath_objects-10.0.beta0] ERROR: No matching distribution found for sage-setup~=10.0b0

(sage-setup was not built as a wheel)

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 88.57% // Head: 88.59% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (09bfd32) compared to base (52a81cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35143      +/-   ##
===========================================
+ Coverage    88.57%   88.59%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397273              
===========================================
+ Hits        351891   351963      +72     
+ Misses       45382    45310      -72     
Impacted Files Coverage Δ
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
...sage/geometry/hyperbolic_space/hyperbolic_model.py 88.95% <0.00%> (-0.62%) ⬇️
src/sage/doctest/forker.py 80.24% <0.00%> (-0.54%) ⬇️
src/sage/graphs/generators/random.py 91.95% <0.00%> (-0.52%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.66% <0.00%> (-0.48%) ⬇️
src/sage/doctest/reporting.py 74.45% <0.00%> (-0.44%) ⬇️
src/sage/cpython/_py2_random.py 76.03% <0.00%> (-0.42%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe self-assigned this Feb 18, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 09bfd32

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2023

After make distclean, ./bootstrap && ./configure && make -j4 failed. It just failed. There is no log that I can report...

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 23, 2023

I checked again. By "no log", I mean

...
[numpy-1.23.5] Finished installing numpy-1.23.5
make[2]: *** [all-start] Error 2

real	28m53.666s
user	95m30.385s
sys	18m20.515s
***************************************************************
Error building Sage.

The following package(s) may have failed to build (not necessarily
during this run of 'make all-start'):

It is safe to delete any log files and build directories, but they
contain information that is helpful for debugging build problems.
WARNING: If you now run 'make' again, the build directory of the
same version of the package will, by default, be deleted. Set the
environment variable SAGE_KEEP_BUILT_SPKGS=yes to prevent this.

make[1]: *** [all-start] Error 1
make: *** [all] Error 2

I don't know what went wrong.

…_sagemath_standard_through_sagemath__categories_environment_repl_
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 23, 2023

Thanks for testing! I'll merge current develop and take a look.

…h_sagemath__categories_environment_repl_

SageMath version 10.0.beta6, Release Date: 2023-03-26
@mkoeppe mkoeppe modified the milestones: sage-10.0, sage-10.1 Apr 30, 2023
@mkoeppe mkoeppe removed this from the sage-10.1 milestone Aug 7, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2023

Closing; better version in #35095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor sagemath-standard through sagemath-{categories,environment,repl}
3 participants