-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.geometry.integral_points
: Use generic impl if no matrix_integer_dense
#35135
sage.geometry.integral_points
: Use generic impl if no matrix_integer_dense
#35135
Conversation
…teger_dense is not available
sage.geometry.integral_points
: Use generic impl if no matrix_integer_dense
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35135 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 2140 2141 +1
Lines 396961 396965 +4
========================================
+ Hits 351671 351703 +32
+ Misses 45290 45262 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Documentation preview for this PR is ready! 🎉 |
@@ -0,0 +1,6 @@ | |||
#cython: wraparound=False, boundscheck=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding, this file will just not build, if flint is not present.
From my quick "research" of the state of things, this file will not be included in a sage polyhedra distribution, if flint is not present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which modules are included in any distribution is static.
This module is simply not included in sagemath-polyhedra and will be provided by a different distribution.
Thanks for the review! |
📚 Description
This is for the distribution sagemath-polyhedra (#32432) so that it does not have to depend on the flint library.
📝 Checklist
⌛ Dependencies