Integer and Rational classes need nth_root and exact_power functions #8
Comments
|
comment:1
Fixed. Fri Sep 15 17:19:10 PDT 2006 dmharvey@math.harvard.edu
Fri Sep 15 17:18:20 PDT 2006 dmharvey@math.harvard.edu
|
vbraun
pushed a commit
that referenced
this issue
Mar 26, 2023
### 📚 Description Trac branch `u/gh-collares/gap-gc` from #34701, now migrated to GitHub. Currently based atop #35093; will rebase once that is merged. The rest of the description below is copied from #34701: A refactor in #27946 introduced "unprotected" (not surrounded by `GAP_Enter`/`GAP_Leave`) `GAP_ValueGlobalVariable` calls. I believe this might be a GC hazard, because after updating to GAP 4.12.1 I started seeing aarch64 crashes on NixOS infrastructure such as: ``` #0 0x0000fffff79740e8 in wait4 () #1 0x0000fffff5dc6b78 in print_enhanced_backtrace () #2 0x0000fffff5dc8190 in sigdie () #3 0x0000fffff5dcb1c0 in cysigs_signal_handler () #4 0x0000fffff7ffb7cc in __kernel_rt_sigreturn () #5 0x0000ffff99a0bf28 in ConvString () #6 0x0000000000000000 in ?? () #7 0x0000000000000000 in ?? () #8 0x0000000000000000 in ?? () #9 0x0000ffff99989930 in Pr () #10 0x0000ffff9998aa18 in CloseOutput () #11 0x0000ffff99884828 in capture_stdout () at /build/sage- src-9.7/pkgs/sagemath-standard/sage/libs/gap/element.pyx:154 ... ``` I also see cases where `capture_stdout` throws errors such as `sage.libs.gap.util.GAPError: Error, Length: <list> must be a list (not the integer 255)` and then crashes. Both types of errors are fixed by this ticket. Note that I am nesting `GAP_Enter`/`GAP_Leave` calls because I didn't remove the preexisting calls inside `capture_stdout`. That's because I feared removing the innermost calls might create a new footgun (and I believe nested `GAP_Enter`/`GAP_Leave` calls are explicitly supported), but removing them should cause no problem. Removing them might even be preferable for performance reasons, I don't know. Fixes #34701 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - #35093: GAP 4.12.2 upgrade, which touches the same function and should land first. URL: #35114 Reported by: Mauricio Collares Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
that referenced
this issue
Jun 3, 2023
jsantillan3
added a commit
to jsantillan3/sage
that referenced
this issue
Jul 28, 2023
…block_matrix_form, summand_matrices (sagemath#8) * wip onesum * wip onesum2 * wip onesum test * onesum node example * fixed names of .summand_matrices() and .block_matrix_form, ....: and added examples to ._children() * style fixes --------- Co-authored-by: J S <javier@javiers-mbp.mynetworksettings.com> Co-authored-by: J S <javier@campus-017-091.ucdavis.edu>
xuluze
pushed a commit
to xuluze/sage
that referenced
this issue
Dec 12, 2023
…block_matrix_form, summand_matrices (sagemath#8) * wip onesum * wip onesum2 * wip onesum test * onesum node example * fixed names of .summand_matrices() and .block_matrix_form, ....: and added examples to ._children() * style fixes --------- Co-authored-by: J S <javier@javiers-mbp.mynetworksettings.com> Co-authored-by: J S <javier@campus-017-091.ucdavis.edu>
xuluze
pushed a commit
to xuluze/sage
that referenced
this issue
Feb 23, 2024
…block_matrix_form, summand_matrices (sagemath#8) * wip onesum * wip onesum2 * wip onesum test * onesum node example * fixed names of .summand_matrices() and .block_matrix_form, ....: and added examples to ._children() * style fixes --------- Co-authored-by: J S <javier@javiers-mbp.mynetworksettings.com> Co-authored-by: J S <javier@campus-017-091.ucdavis.edu>
xuluze
pushed a commit
to xuluze/sage
that referenced
this issue
Jun 10, 2024
…block_matrix_form, summand_matrices (sagemath#8) * wip onesum * wip onesum2 * wip onesum test * onesum node example * fixed names of .summand_matrices() and .block_matrix_form, ....: and added examples to ._children() * style fixes --------- Co-authored-by: J S <javier@javiers-mbp.mynetworksettings.com> Co-authored-by: J S <javier@campus-017-091.ucdavis.edu>
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jan 23, 2025
….0 to 0.2.1
Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz-
ops/install-gh-cli-action) from 0.2.0 to 0.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh-
cli-action/releases">dev-hanz-ops/install-gh-cli-action's
releases</a>.</em></p>
<blockquote>
<h2>v0.2.1 - arm64 support</h2>
<ul>
<li>support arm64 architecture - <a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/pull/10">dev-hanz-ops/install-gh-cli-action#10</a> (by <a href="h
ttps://github.com/whatthefinemanual"><code>@whatthefinemanual</code></a
>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/af38ce09b1ec248aeb08eea2b16bbecea9e059f8"><code>af38ce0</code></a> run
build</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/eef2976cedc1da9b4b4eafcdf96655455d55ac73"><code>eef2976</code></a>
feature: Add multi architecture support (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/10">sagemath#10</a>)</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/2d19dc38f3a568abbd2a42dae05be5b83202f332"><code>2d19dc3</code></a>
docs: update recomended action version (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/8">sagemath#8</a>)</li>
<li>See full diff in <a href="https://github.com/dev-hanz-ops/install-
gh-cli-action/compare/v0.2.0...v0.2.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-
vulnerabilities/about-dependabot-security-updates#about-compatibility-
scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
URL: sagemath#39352
Reported by: dependabot[bot]
Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jan 25, 2025
….0 to 0.2.1
Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz-
ops/install-gh-cli-action) from 0.2.0 to 0.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh-
cli-action/releases">dev-hanz-ops/install-gh-cli-action's
releases</a>.</em></p>
<blockquote>
<h2>v0.2.1 - arm64 support</h2>
<ul>
<li>support arm64 architecture - <a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/pull/10">dev-hanz-ops/install-gh-cli-action#10</a> (by <a href="h
ttps://github.com/whatthefinemanual"><code>@whatthefinemanual</code></a
>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/af38ce09b1ec248aeb08eea2b16bbecea9e059f8"><code>af38ce0</code></a> run
build</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/eef2976cedc1da9b4b4eafcdf96655455d55ac73"><code>eef2976</code></a>
feature: Add multi architecture support (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/10">sagemath#10</a>)</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/2d19dc38f3a568abbd2a42dae05be5b83202f332"><code>2d19dc3</code></a>
docs: update recomended action version (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/8">sagemath#8</a>)</li>
<li>See full diff in <a href="https://github.com/dev-hanz-ops/install-
gh-cli-action/compare/v0.2.0...v0.2.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-
vulnerabilities/about-dependabot-security-updates#about-compatibility-
scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
URL: sagemath#39352
Reported by: dependabot[bot]
Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jan 26, 2025
….0 to 0.2.1
Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz-
ops/install-gh-cli-action) from 0.2.0 to 0.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh-
cli-action/releases">dev-hanz-ops/install-gh-cli-action's
releases</a>.</em></p>
<blockquote>
<h2>v0.2.1 - arm64 support</h2>
<ul>
<li>support arm64 architecture - <a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/pull/10">dev-hanz-ops/install-gh-cli-action#10</a> (by <a href="h
ttps://github.com/whatthefinemanual"><code>@whatthefinemanual</code></a
>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/af38ce09b1ec248aeb08eea2b16bbecea9e059f8"><code>af38ce0</code></a> run
build</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/eef2976cedc1da9b4b4eafcdf96655455d55ac73"><code>eef2976</code></a>
feature: Add multi architecture support (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/10">sagemath#10</a>)</li>
<li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi
t/2d19dc38f3a568abbd2a42dae05be5b83202f332"><code>2d19dc3</code></a>
docs: update recomended action version (<a
href="https://redirect.github.com/dev-hanz-ops/install-gh-cli-
action/issues/8">sagemath#8</a>)</li>
<li>See full diff in <a href="https://github.com/dev-hanz-ops/install-
gh-cli-action/compare/v0.2.0...v0.2.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-
vulnerabilities/about-dependabot-security-updates#about-compatibility-
scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
URL: sagemath#39352
Reported by: dependabot[bot]
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be useful for Integer and Rational classes to have:
(1) nth_root: this would wrap GMP's mpz_root.
(2) exact_power: would accept a rational number as an index, and work out which root to take. For example
(-8/27).exact_power(2/3) == 4/9
I had to take an exact 6th root of a rational in some code the other day and it was painful going via real numbers, worrying about bits of precision and all that.
Component: basic arithmetic
Issue created by migration from https://trac.sagemath.org/ticket/8
The text was updated successfully, but these errors were encountered: