Support tox 4

[mkoeppe]

tox 4 renamed a tox.ini configuration keyword and has slightly changed quoting behavior.

Also tox >= 3.18 supports the renamed keyword - https://tox.wiki/en/3.27.1/changelog.html#v3-18-0-2020-07-23

Also the changed quote works with both versions.

Component: packages: standard

Author: Matthias Koeppe, Frédéric Chapoton

Branch/Commit: 70da140

Reviewer: Frédéric Chapoton, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34839

[mkoeppe]

Branch: u/mkoeppe/support_tox_4

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

d302a62

tox.ini, src/tox.ini: Adjust to tox 4, autoprovision tox >= 3.18

[mkoeppe]

Commit: d302a62

[fchapoton]

comment:4

The linter is finding rst issues outside of src/sage. Is this the desired behaviour ?

By the way, one should rather fix these issues.

[sagetrac-git]

Changed commit from d302a62 to f8703ae

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f8703ae

.github/workflows/lint.yml: Invoke tox with --

[mkoeppe]

comment:6

relint is fixed now - is this what you meant?

[fchapoton]

comment:7

no. I am talking about the errors seen in the third report

https://github.com/sagemath/sagetrac-mirror/actions/runs/3674822970/jobs/6213509002

[fchapoton]

Changed commit from f8703ae to 9d76204

[fchapoton]

Changed branch from u/mkoeppe/support_tox_4 to u/chapoton/support_tox_4

[fchapoton]

comment:8

I have tried to fix these errors, let us see

---

New commits:

9d76204

fix some rst issues in sage_docbuild and sage_setup

[fchapoton]

comment:9

looks good to me. Please check my commit and then set to positive.

[fchapoton]

Reviewer: Frédéric Chapoton

[mkoeppe]

comment:10

Thanks!

[mkoeppe]

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Matthias Koeppe

[mkoeppe]

Changed author from Matthias Koeppe to Matthias Koeppe, Frédéric Chapoton

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

70da140

Merge branch 'u/chapoton/support_tox_4' in 9.8.b6

[sagetrac-git]

Changed commit from 9d76204 to 70da140

[fchapoton]

comment:12

setting back to positive after trivial rebase

[mkoeppe]

comment:13

"Critical" because it repairs the broken Lint workflow

[vbraun]

Changed branch from u/chapoton/support_tox_4 to 70da140