-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation guide: Improve section on prerequisites/recommendations #34528
Comments
Dependencies: #34266 |
This comment has been minimized.
This comment has been minimized.
Commit: |
Last 10 new commits:
|
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:18
And the dependency on #34266 is just because that ticket is updating the documentation regarding GCC requirements, so it's merged here to avoid merge conflicts later. |
comment:20
Here are a few small edits. Should something about Apple's M1/M2 be added to the New commits:
|
comment:24
My understanding is that you only need to use the bootstrap command if you are testing new packages. If you are working solely within the Sage library, you shouldn't need it. |
comment:25
That's right. |
comment:26
But in the manual we actually do say that it is a hard requirement:
This sentence appears in the section explaining the prerequisites. |
comment:27
We used to explain in a more fine-grained way when |
comment:28
Replying to Tobias Diez:
I think you missed the paragraph leading to the section with these long generated command-lines:
|
comment:29
Assuming that the tests go well in #33816, we can remove the paragraph about m1/m2 from the |
comment:30
For |
comment:31
I was thinking of this change: diff --git a/build/pkgs/gcc/SPKG.rst b/build/pkgs/gcc/SPKG.rst
index 87a056f83d..cc6c8153a8 100644
--- a/build/pkgs/gcc/SPKG.rst
+++ b/build/pkgs/gcc/SPKG.rst
@@ -42,6 +42,11 @@ you need a recent version of Xcode.
(Installing the
``gfortran`` SPKG becomes a no-op in this case.)
+Building Sage from source on Apple Silicon (M1/M2) requires the use of
+Apple's Command Line Tools, and those tools include a suitable
+compiler. Sage's ``gcc`` SPKG is not suitable for M1/M2; building it
+will likely fail.
+
License
-------
diff --git a/build/pkgs/gfortran/SPKG.rst b/build/pkgs/gfortran/SPKG.rst
index b6ba9b9bb4..9559b98456 100644
--- a/build/pkgs/gfortran/SPKG.rst
+++ b/build/pkgs/gfortran/SPKG.rst
@@ -20,13 +20,6 @@ need to run::
$ ./configure CC=clang CXX=clang++ FC=flang
-Building Sage from source on Apple Silicon (M1/M2) requires the use of
-the `Homebrew package manager <https://brew.sh>`_ (recommended) or
-conda-forge, which package versions of GCC 12.x (including
-``gfortran``) with the necessary changes for this platform. These
-changes are not in a released upstream version of GCC, and hence
-the ``gfortran`` SPKG is not suitable for the M1/M2.
-
License
-------
|
comment:32
Please go ahead and push it to the ticket. We can make #33816 a dependency. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:34
Replying to John Palmieri:
Thanks for the clarification. I was always under the impression that bootstrap was needed after a git clone, good to know that this is no longer the case. |
comment:36
Replying to Matthias Köppe:
Done, plus some details from #32074 New commits:
|
Changed author from Matthias Koeppe to Matthias Koeppe, John Palmieri |
Reviewer: John Palmieri, ... |
comment:40
I'm happy with Matthias' contributions; positive review from me. |
Changed reviewer from John Palmieri, ... to John Palmieri, Matthias Koeppe |
comment:41
Thanks! |
Changed branch from u/jhpalmieri/installation_guide__improve_section_on_prerequisites_recommendations to |
We move the details regarding required compilers, binutils, etc. from the installation manual to the respective SPKG.rst files (except for the
tk
stuff, for which we don't have a package - #31206). Most users who install from source do not need this level of detail.This change will give the simple installation instructions (with prepared package installation commands) more prominence.
Preview of the updated section
Depends on #34266
Depends on #33816
CC: @tobiasdiez @egourgoulhon @Kerl13 @dimpase @jhpalmieri
Component: documentation
Author: Matthias Koeppe, John Palmieri
Branch/Commit:
5b9b5a0
Reviewer: John Palmieri, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34528
The text was updated successfully, but these errors were encountered: