Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for GCC < 8 in Sage 9.8 #34266

Closed
mkoeppe opened this issue Aug 3, 2022 · 19 comments
Closed

Drop support for GCC < 8 in Sage 9.8 #34266

mkoeppe opened this issue Aug 3, 2022 · 19 comments
Labels
c: build: configure p: critical / 2 t: enhancement
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2022

(see #32074)

Depends on #33062

CC: @dimpase

Component: build: configure

Author: Matthias Koeppe

Branch: 27a0882

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34266
@mkoeppe mkoeppe added this to the sage-9.8 milestone Aug 3, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Dependencies: #32074

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Changed dependencies from #32074 to #32074, #33062

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Branch: u/mkoeppe/drop_support_for_gcc___8_in_sage_9_8

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Last 10 new commits:

f2b52ef.github/workflows/ci-linux.yml: First run all 'standard' jobs, then 'minimal', ...
ca6d163.github/workflows/ci-linux.yml: Rename stages
5713937sage -package list --has-file, --no-file: Handle disjunctions
8c7e0c4Merge #33062
4e8ec60.github/workflows/docker.yml: Remove debian-stretch, fedora-{26,27,27}
a9f4b15tox.ini (gcc_8), build/pkgs/_gcc8: New
120ab05tox.ini (envlist): Replace docker-ubuntu-trusty-minimal with docker-ubuntu-trusty-toolchain-gcc_9-minimal
9b38badbuild/pkgs/_gcc{9,10,11}/distros/opensuse.txt: New
ccce5b1.github/workflows/docker.yml: Use gcc_8 with ubuntu-bionic, linuxmint-19.x
27a0882.github/workflows/docker.yml: Use gcc_11 with opensuse-15.{3,4}

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Commit: 27a0882

@dimpase
Copy link
Member

dimpase commented Aug 16, 2022

comment:5

why is #32074 (a meta-ticket) listed as a dependency here?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 16, 2022

comment:6

So that it doesn't get accidentally merged into Sage 9.7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 20, 2022

comment:7

Let's get this in please

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 20, 2022

Changed dependencies from #32074, #33062 to #33062

@dimpase
Copy link
Member

dimpase commented Sep 21, 2022

comment:8

what's happening to workflow/tox-* ? why is it being removed?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 21, 2022

comment:9

These tests have been merged into ci-linux.yml (actually done in #33062)

@dimpase
Copy link
Member

dimpase commented Sep 21, 2022

comment:10

OK

@dimpase
Copy link
Member

dimpase commented Sep 21, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 21, 2022

comment:11

Thank you!

@vbraun
Copy link
Member

vbraun commented Sep 25, 2022

Changed branch from u/mkoeppe/drop_support_for_gcc___8_in_sage_9_8 to 27a0882

@vbraun vbraun closed this as completed in 9651672 Sep 25, 2022
@dimpase
Copy link
Member

dimpase commented Oct 20, 2022

Changed commit from 27a0882 to none

@dimpase
Copy link
Member

dimpase commented Oct 20, 2022

comment:13

this should have removed no longer relevant build/pkgs/flint/patches/0001-flint.h-On-GCC-4.9-do-not-use-_Thread_local.patch

@dimpase
Copy link
Member

dimpase commented Oct 21, 2022

comment:14

Replying to Dima Pasechnik:

this should have removed no longer relevant build/pkgs/flint/patches/0001-flint.h-On-GCC-4.9-do-not-use-_Thread_local.patch

this is tracked in #34682

This was referenced Jan 6, 2023
Open
Closed
vbraun pushed a commit that referenced this issue Feb 11, 2023
Trac #34682: clean up old gcc < 8 patches
4c4fcd0 
One of these left after #34266 is

`build/pkgs/flint/patches/0001-flint.h-On-GCC-4.9-do-not-use-
_Thread_local.patch`

there are more (see the branch)

URL: https://trac.sagemath.org/34682
Reported by: dimpase
Ticket author(s): Dima Pasechnik
Reviewer(s): Matthias Koeppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe