Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 3) #34357

Closed
dcoudert opened this issue Aug 13, 2022 · 12 comments
Closed

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 3) #34357

dcoudert opened this issue Aug 13, 2022 · 12 comments
Labels
c: graph theory p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@dcoudert
Copy link
Contributor

This is a follow up of #34318 and #34319.

Depends on #34319

Component: graph theory

Author: David Coudert

Branch/Commit: 8704f2b

Reviewer: Sebastian Oehms

Issue created by migration from https://trac.sagemath.org/ticket/34357
@dcoudert dcoudert added this to the sage-9.7 milestone Aug 13, 2022
@dcoudert

This comment has been minimized.

Sign in to view
@dcoudert
Copy link
Contributor Author

New commits:

598744etrac #34357: clean src/sage/graphs/generic_graph.py - part 3

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/34357_gen3

@dcoudert
Copy link
Contributor Author

Commit: 598744e

@soehms
Copy link
Member

soehms commented Aug 17, 2022

comment:2

Is there a special reason why this is not on top of the branch of #34319?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

444a55atrac #34318: clean src/sage/graphs/generic_graph.py - part 1
328cc6atrac #34318: fix pyflakes issue
b62e29etrac #34319: clean src/sage/graphs/generic_graph.py - part 2
dc4bcbdtrac #34319: merge with #34318
8704f2btrac #34357: merge with #34319

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from 598744e to 8704f2b

@dcoudert
Copy link
Contributor Author

comment:4

I have rebased on #34319.

@dcoudert
Copy link
Contributor Author

Dependencies: #34319

@soehms
Copy link
Member

soehms commented Aug 20, 2022

comment:5

The patchbot failures are unrelated.

@soehms
Copy link
Member

soehms commented Aug 20, 2022

Reviewer: Sebastian Oehms

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from public/graphs/34357_gen3 to 8704f2b

@vbraun vbraun closed this as completed in 4f9e201 Aug 30, 2022
@dcoudert dcoudert mentioned this issue Sep 27, 2022
Closed
@vbraun vbraun mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @mkoeppe @dcoudert @soehms