Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 2) #34319

Closed
dcoudert opened this issue Aug 9, 2022 · 9 comments
Closed

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 2) #34319

dcoudert opened this issue Aug 9, 2022 · 9 comments
Labels
c: graph theory p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Aug 9, 2022

We continue the cleaning of src/sage/graphs/generic_graph.py.

Depends on #34318

Component: graph theory

Author: David Coudert

Branch/Commit: dc4bcbd

Reviewer: Sebastian Oehms

Issue created by migration from https://trac.sagemath.org/ticket/34319
@dcoudert dcoudert added this to the sage-9.7 milestone Aug 9, 2022
@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

New commits:

444a55atrac #34318: clean src/sage/graphs/generic_graph.py - part 1
b62e29etrac #34319: clean src/sage/graphs/generic_graph.py - part 2

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

Commit: b62e29e

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

Branch: public/graphs/34319_gen2

@soehms
Copy link
Member

soehms commented Aug 17, 2022

comment:3

If you merge with the current commit of the branch of #34318 you may set this to positive review, as well.

@soehms
Copy link
Member

soehms commented Aug 17, 2022

Reviewer: Sebastian Oehms

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from b62e29e to dc4bcbd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

328cc6atrac #34318: fix pyflakes issue
dc4bcbdtrac #34319: merge with #34318

@dcoudert
Copy link
Contributor Author

comment:5

Done. Thank you.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from public/graphs/34319_gen2 to dc4bcbd

@vbraun vbraun closed this as completed in 1cc4209 Aug 30, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
@dcoudert dcoudert mentioned this issue Aug 30, 2022
Closed
@vbraun vbraun mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @mkoeppe @dcoudert @soehms