Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.combinat.finite_state_machine: Remove use of "var" #34217

Closed
mkoeppe opened this issue Jul 25, 2022 · 11 comments
Closed

sage.combinat.finite_state_machine: Remove use of "var" #34217

mkoeppe opened this issue Jul 25, 2022 · 11 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 25, 2022

It should use SR.symbol() instead.

We also remove some unnecessary uses of SR and mark some doctests # optional - sage.symbolic (for #32601).

CC: @cheuberg @dkrenn @tscrim

Component: combinatorics

Author: Matthias Koeppe

Branch/Commit: 6e49510

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34217
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 25, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2022

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2022

Branch: u/mkoeppe/sage_combinat_finite_state_machine__remove_use_of__var_

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2022

Commit: 6e49510

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2022

New commits:

c78763dsrc/sage/combinat/finite_state_machine.py: Import trigs from math, not sage.functions.trig
19182f8src/sage/combinat/finite_state_machine.py: Do not use global var
6e49510src/sage/combinat/finite_state_machine.py: Mark some doctests # optional - sage.symbolic

@tscrim
Copy link
Collaborator

tscrim commented Aug 2, 2022

comment:6

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 2, 2022

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 2, 2022

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 6, 2022

Changed branch from u/mkoeppe/sage_combinat_finite_state_machine__remove_use_of__var_ to 6e49510

@vbraun vbraun closed this as completed in de447ff Aug 6, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#34217
41ebe9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe