-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.functions.log.log: Move to sage.misc.functional #32794
Comments
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:9
Green bot, please review |
Reviewer: Dima Pasechnik |
comment:10
lgtm |
comment:11
It would be a little cleaner if the import in |
comment:12
I kept this one (in |
comment:13
Thanks for the review! |
Changed branch from u/mkoeppe/sage_functions_log_log__move_to_sage_misc_functions to |
sage.functions
is the home for symbolic functions; this package will not be included in the distribution package sagemath-standard-no-symbolics (#32601), nor in smaller distributions such as sagemath-polyhedra (#32432).sage.functions.log.log
is not a symbolic function but only wrapper def that either delegates to a symbolic function or calls a method. We move it tosage.misc.functional
so that non-symbolic uses of it do not pull in symbolics; and change these imports.There is already a function
log
insage.misc.functional
, deprecated since #19444 (Sage 8.1). We replace it.We keep a non-deprecated import of
log
insage.functions.log
for symbolic uses.Similar to what was done in #32717 for
sqrt
.CC: @tscrim @jhpalmieri @fchapoton @seblabbe @videlec @dimpase
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
238e97e
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32794
The text was updated successfully, but these errors were encountered: