Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.modules, sage.matrix: Remove import-time dependencies on the symbolic ring #32593

Closed
mkoeppe opened this issue Sep 30, 2021 · 8 comments
Closed

sage.modules, sage.matrix: Remove import-time dependencies on the symbolic ring #32593

mkoeppe opened this issue Sep 30, 2021 · 8 comments
Labels
c: linear algebra p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 30, 2021

(cherry-picked from #32432)

CC: @kliem @tscrim

Component: linear algebra

Author: Matthias Koeppe

Branch/Commit: acca6c2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32593
@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 30, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Branch: u/mkoeppe/sage_modules__sage_matrix__remove_import_time_dependencies_on_the_symbolic_ring

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Commit: acca6c2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

New commits:

1b0a5absrc/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present
83b5038src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method
acca6c2src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2021

comment:3

LGTM (assuming a green patchbot).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

Changed branch from u/mkoeppe/sage_modules__sage_matrix__remove_import_time_dependencies_on_the_symbolic_ring to acca6c2

@vbraun vbraun closed this as completed in db48512 Oct 13, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32593
7f2bfd1
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32593
e438157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe