Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphinx's install-requires.txt #32575

Closed
jhpalmieri opened this issue Sep 27, 2021 · 7 comments
Closed

Fix sphinx's install-requires.txt #32575

jhpalmieri opened this issue Sep 27, 2021 · 7 comments
Labels
c: packages: standard p: major / 3 t: bug
Milestone
sage-9.5

Comments

@jhpalmieri
Copy link
Member

The Sphinx update to 4.2.0 didn't include a fix for the file install-requires.txt. Let's fix that.

Component: packages: standard

Author: John Palmieri

Branch/Commit: adae38e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32575
@jhpalmieri jhpalmieri added this to the sage-9.5 milestone Sep 27, 2021
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/sphinx-install-requires

@jhpalmieri
Copy link
Member Author

New commits:

adae38etrac 32575: Sphinx's install-requires.txt: allow version 4.2

@jhpalmieri
Copy link
Member Author

Commit: adae38e

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 27, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 27, 2021

comment:3

Thanks for catching this!

@jhpalmieri
Copy link
Member Author

comment:4

Replying to @mkoeppe:

Thanks for catching this!

It was just luck, really: my Sage build had paused when I happened to look at the screen and saw a line in the networkx install starting "ERROR".

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

Changed branch from u/jhpalmieri/sphinx-install-requires to adae38e

@vbraun vbraun closed this as completed in 25548ba Oct 13, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32575
1131c86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe