Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognizable series: basic arithmetic #21318

Closed
dkrenn opened this issue Aug 23, 2016 · 54 comments
Closed

recognizable series: basic arithmetic #21318

dkrenn opened this issue Aug 23, 2016 · 54 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 23, 2016

  • Make recognizable series space a module (addition, scalar multiplication)
  • Hadamard product

See also meta ticket #21202

Depends on #21203

Component: combinatorics

Author: Daniel Krenn

Branch/Commit: 14291eb

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/21318
@dkrenn dkrenn added this to the sage-7.4 milestone Aug 23, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Branch: u/dkrenn/sequences/rec-basic-arith

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Commit: d8a9173

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Author: Daniel Krenn

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 23, 2016

Last 10 new commits:

a7a89acdimension
8c519f7_add_
0133b6e_neg_
75a976e_rmul_ and _lmul_
6bd4380change category to modules
d009fd2Merge commit 'rec-basic-arith' into u/dkrenn/sequences/rec-basic-arith
bf12207hadamard_product
13e32d7subsequence
4543d7bdoctesting all parameters in coefficient_of_word
d8a9173doctesting rmul, lmul and one_hadamard

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2016

Changed commit from d8a9173 to 1882b17

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0c7db8ahandle mutable structures
1ba61b1fix doctests
33209damutability in transposed()
f0de605hashing
1882b17equality testing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2016

Changed commit from 1882b17 to d8a9173

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2016

Changed commit from d8a9173 to b76bf4e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

01495cbextend to negative shifts in subsequence
b76bf4efactor out subsequence to separat ticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

5919120doctesting all parameters in coefficient_of_word
c7243a6Merge tag '7.4.beta1' into t/21295/sequences/recognizable
4012778Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
5dbedabfix doctests (experimental warning)
143ea73fix building of docs (no idea why it failed)
6247a7fMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from b76bf4e to 6247a7f

@dkrenn

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 6247a7f to 0fc3d42

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e7d2114minor correction in doc
0fc3d42solve troubles with doc-building

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 0fc3d42 to 291faf9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

d5c378dsolve troubles with doc-building
291faf9Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 291faf9 to 019c161

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

019c161remove zero()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 019c161 to c0ade99

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e03a32fMerge tag '7.4.beta2' into t/21180/cantor_product_comb
642cceeMerge branch 't/21180/cantor_product_comb' into t/21203/sequences/k-regular
352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable
914640fMerge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
c0ade99Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:12

patchbot python3 plugin failuree

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a6b5561Trac #21295: fix ReST error
c9c3408Trac #21295: fix typos
4fe1a56Merge tag '7.5' into t/21295/sequences/recognizable
5848353Python3: __nonzero__
4a43407Python3: izip
4970cf5Python3: absolute import
e33a3c9Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
4da9796Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
13b536ePython3: absolut import
5919c4dMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith

@cheuberg
Copy link
Contributor

comment:28

Thank you. Do you have any idea why E * 2 calls E._lmul_ twice (for 2 * E, E._rmul_ is called once, as expected) in the newly written test in _rmul_?

Apart from that question, I think that this ticket is ready to be merged once a patchbot is happy (might be some time because of #32048).

@dkrenn
Copy link
Contributor Author

dkrenn commented Jun 27, 2021

comment:29

Replying to @cheuberg:

Thank you. Do you have any idea why E * 2 calls E._lmul_ twice (for 2 * E, E._rmul_ is called once, as expected) in the newly written test in _rmul_?

Yes. The first left and right, resp., scalar multiplication that is performed in a session has one additional call coming from the coercion framework after discovering the action, because, when I remember correctly, a dummy multiplication is performed to check if that works. Now 2 * E is computed earlier in the test, so this additional call of _rmul_ is done there (but not seen). Removing the tests 2 * E and also 1 * E results in the same behavior for both _rmul_ and _lmul_.

Apart from that question, I think that this ticket is ready to be merged once a patchbot is happy (might be some time because of #32048).

I'll put it to positive_review.

@dkrenn
Copy link
Contributor Author

dkrenn commented Jun 27, 2021

comment:30

Replying to @dkrenn:

I'll put it to positive_review.

Back to needs_review as the patchbot has not run yet.

@cheuberg
Copy link
Contributor

cheuberg commented Jul 4, 2021

comment:31

The pyflakes finding by the patchbot should be adressed:

src/sage/combinat/recognizable_series.py:1672:9 'sage.rings.integer_ring.ZZ' imported but unused

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Changed commit from c70f8db to 14291eb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

14291ebTrac #21318: remove unused import (pyflakes)

@dkrenn
Copy link
Contributor Author

dkrenn commented Jul 6, 2021

comment:33

Replying to @cheuberg:

The pyflakes finding by the patchbot should be adressed:

src/sage/combinat/recognizable_series.py:1672:9 'sage.rings.integer_ring.ZZ' imported but unused

Done.

@cheuberg
Copy link
Contributor

cheuberg commented Jul 6, 2021

comment:34

Thank you. Feel free to set to positive review once the patchbot is happy.

@vbraun
Copy link
Member

vbraun commented Jul 9, 2021

Changed branch from u/dkrenn/sequences/rec-basic-arith to 14291eb

@vbraun vbraun closed this as completed in a33399f Jul 9, 2021
This was referenced Dec 29, 2022
Open
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
e726278 
…gular-guess

* t/21319/sequences/rec-hash: (11520 commits)
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  Trac sagemath#21203 review issue 5: meaningful error message in _n_to_index_
  Trac sagemath#21203 review issue 8: resolve "`n`th" in docstring
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
5ce5276 
…gular-guess

* t/21319/sequences/rec-hash:
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
8488b55 
…ar-warning

* t/21204/sequences/k-regular-guess: (11522 commits)
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
fb5fb62 
…ar-warning

* t/21204/sequences/k-regular-guess:
  Trac sagemath#21204: fix punctuation
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 't/21343/k-regular-warning' into t/22964/k-regular-bounded
b44bdad 
* t/21343/k-regular-warning: (11523 commits)
  Trac sagemath#21343: adapt to removed transpose-property in dependency
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
3 participants
@vbraun @cheuberg @dkrenn