Skip to content

Commit

Permalink
Trac #33631: Github workflow: Fix pyright
Browse files Browse the repository at this point in the history
Pyrights recent versions introduced some memory overflow issues, see
microsoft/pyright#3239. This broke our github
workflow that runs for every ticket.

In fact, we have two runs of pyright on `develop` that only differ in
the (automatic) upgrade 232 > 233, see
https://github.com/sagemath/sage/runs/5710759985?check_suite_focus=true
(works)
https://github.com/sagemath/sage/runs/5710763334?check_suite_focus=true
(fails).

In this ticket, we fix the pyright the last working version 232.

URL: https://trac.sagemath.org/33631
Reported by: gh-tobiasdiez
Ticket author(s): Tobias Diez
Reviewer(s): Matthias Koeppe
  • Loading branch information
Release Manager committed Apr 2, 2022
2 parents 78bfb6c + a07dc72 commit 88e25dd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ jobs:
node-version: '12'

- name: Install pyright
run: npm install -g pyright
# Fix to v232 due to bug https://github.com/microsoft/pyright/issues/3239
run: npm install -g pyright@1.1.232

- name: Prepare
run: |
Expand Down

0 comments on commit 88e25dd

Please sign in to comment.