Skip to content

Commit

Permalink
Trac #33174: Unreachable code in sage/graphs/base/c_graph.pyx
Browse files Browse the repository at this point in the history
The body of this function is unreachable,

{{{#!python
cdef bint _has_labeled_edge_unsafe(self, int u_int, int v_int, object l)
except -1:
    """
    Return whether ``self`` has an arc specified by indices of the
vertices
    and an arc label.
    """
    raise NotImplementedError
    cdef int l_int
    if l is None:
        l_int = 0
    else:
        l_int = self.new_edge_label(l)
    return self.cg().has_arc_unsafe(u_int, v_int, l_int)
}}}

Is it just an oversight?

URL: https://trac.sagemath.org/33174
Reported by: mjo
Ticket author(s): David Coudert
Reviewer(s): Michael Orlitzky
  • Loading branch information
Release Manager committed Feb 16, 2022
2 parents ddd2ab1 + 7852073 commit 22221ae
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=715dad7f3b54899d0b674f8702daeb00b8d91e2a
md5=5cb724577bd74901db4aeee68d871dbd
cksum=1223038546
sha1=24e1f3ea7c5e65fc38ea820e466301524d0b718f
md5=ee6bab958b3e085ffc5d40945f65b2a3
cksum=1756651950
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f9e6ae67e85164f4a1f6fa0b1aac41684ddb8905
006d57f39e98cd9e37fcaae12daf9c1db5629342
6 changes: 0 additions & 6 deletions src/sage/graphs/base/c_graph.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2600,12 +2600,6 @@ cdef class CGraphBackend(GenericGraphBackend):
and an arc label.
"""
raise NotImplementedError
cdef int l_int
if l is None:
l_int = 0
else:
l_int = self.new_edge_label(l)
return self.cg().has_arc_unsafe(u_int, v_int, l_int)

cdef int free_edge_label(self, int l_int) except -1:
raise NotImplementedError()
Expand Down

0 comments on commit 22221ae

Please sign in to comment.