Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for python 3.11 #120

Merged
merged 3 commits into from
Oct 3, 2022
Merged

fix for python 3.11 #120

merged 3 commits into from
Oct 3, 2022

Conversation

kliem
Copy link
Collaborator

@kliem kliem commented Oct 1, 2022

This shall fix #114.

It is supposed to replace:

@kliem kliem requested review from mkoeppe and videlec October 1, 2022 18:54
@mkoeppe
Copy link

mkoeppe commented Oct 1, 2022

@kliem kliem force-pushed the new_fix_for_python_3_11 branch from dc9cb56 to f6bee28 Compare October 1, 2022 20:50
@mkoeppe
Copy link

mkoeppe commented Oct 2, 2022

Builds with "snapshot" are failing, for example https://github.com/sagemath/cypari2/actions/runs/3166111784/jobs/5155607498

Should a test with pari 2.15 be addded? (See https://trac.sagemath.org/ticket/34537)

@kliem
Copy link
Collaborator Author

kliem commented Oct 2, 2022

@mkoeppe: Regarding your first comment, it is always good to add files to github...

The issue with pari > 2.13 is tracked in #111.

Sure we could add tests for 2.14 and 2.15. However, there is a already a lot of tests. Maybe it makes sense to go away from the 2-dimensional solution and instead test various versions of pari with a default python and various versions of python with a default pari.

Or a different approach would be to reuse pari installations for different python versions (similar to some of your sage workflows). That would be lot's faster, wouldn't it?

Copy link

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@videlec
Copy link
Collaborator

videlec commented Oct 3, 2022

Builds with "snapshot" are failing, for example https://github.com/sagemath/cypari2/actions/runs/3166111784/jobs/5155607498

Should a test with pari 2.15 be addded? (See https://trac.sagemath.org/ticket/34537)

Yes. Some tests need to be adapted. Nothing dramatic though. See #111

@kliem kliem merged commit 5ff0c26 into sagemath:master Oct 3, 2022
This was referenced Oct 3, 2022
@videlec
Copy link
Collaborator

videlec commented Oct 3, 2022

Thanks for the fix.

In the future, please avoid to merge branch that do not pass the test suite. Priority is now #111.

@kliem kliem deleted the new_fix_for_python_3_11 branch October 3, 2022 08:47
@kliem
Copy link
Collaborator Author

kliem commented Oct 3, 2022

The tests aren't really working at the moment and yes, pari 2.13 is not yet supported.

@videlec
Copy link
Collaborator

videlec commented Oct 3, 2022

Sure, I know. I was trying to suggest that we could have merged the (not yet available) fix for pari > 2.13 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with python 3.11
4 participants