Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out transform declarations #1

Conversation

gingersnapp
Copy link
Collaborator

@gingersnapp gingersnapp commented Oct 4, 2018

What

Removing transform declarations from Cleanslate

Why

Cleanslate's transform: none !important is overriding the typing indicator animation keyframe transform declarations.

Heres part of the CSS animation that makes the typing indicator bounce:

@keyframes wave {
  0%, 60%, 100% {
    transform: initial !important;
  }
  30% {
    transform: translateY(-3px) !important;
  }
  85% {
    transform: translateY(1px) !important;
  }
}

From MDN: "Declarations in a keyframe qualified with !important are ignored."

The animation is playing on all browsers (Chrome, IE11, Safari) except for Firefox. This is because most browsers allow animations of properties that have been previously qualified with !important whereas Firefox does not allow animations of declarations previously qualified with !important

Testing

Test out the typing indicator in Firefox browser by chatting in and having the agent respond. Note that the animation is moving.

@gingersnapp gingersnapp merged commit c8e6718 into master Oct 4, 2018
@gingersnapp gingersnapp deleted the sarahberger/ch20415/firefox-doesn-t-allow-animations-of-declarations branch October 4, 2018 18:22
@gingersnapp gingersnapp added the bug Something isn't working label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants