Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloading of assets in pmctl #80

Merged
merged 4 commits into from
Jun 20, 2020
Merged

Fix downloading of assets in pmctl #80

merged 4 commits into from
Jun 20, 2020

Conversation

dhaavi
Copy link
Member

@dhaavi dhaavi commented Jun 20, 2020

Also:

  • Remove unneeded index in pmctl for now
  • Improve resilience when handling execution errors in pmctl

@dhaavi dhaavi added this to the Post Factum Reviews milestone Jun 20, 2020
@dhaavi dhaavi merged commit dc35964 into develop Jun 20, 2020
@dhaavi dhaavi deleted the fix/pmctl-download branch June 20, 2020 14:27
@dhaavi dhaavi mentioned this pull request Jun 20, 2020
Closed
7 tasks
ppacher
ppacher reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@ppacher ppacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppacher ppacher removed this from the Post Factum Reviews milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppacher ppacher ppacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaavi @ppacher