Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Configure Role-Based Permissions for Tables #90

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[FEAT]: Configure Role-Based Permissions for Tables #90

wants to merge 9 commits into from

Conversation

coxmars
Copy link

@coxmars coxmars commented Feb 3, 2025

📝 Configure Role-Based Permissions for Tables

🛠️ Issue

📖 Description

Implemented role-based access control (RBAC) for all database tables through dedicated YAML files, following the established pattern from the users table. Changes include:

  • public_apartments.yaml
  • public_apartment_images.yaml
  • public_bid_requests.yaml
  • public_bid_status_histories.yaml
  • public_escrow_transactions.yaml
  • public_escrow_xdr_transactions.yaml
  • public_escrow_api_calls.yaml
  • public_apartment_contracts.yaml

📝 Additional Notes

  • All permission files follow the pattern established in the users table permissions
  • JWT configuration enables Firebase authentication integration
  • Changes maintain backward compatibility with existing functionality

@coxmars
feat: add apartments table with relationships and permissions
9579a49
@coxmars
feat: add permissions and relationships for apartment_images table
4eec54d
@coxmars
eat: add bid_requests table with permissions and relationships for te…
d742aaf 
…nants and landlords
@coxmars
feat: add bid_status_histories table with permissions for tenants and…
0f7f8af 
… landlords
@coxmars
feat: add escrow_transactions table with permissions for tenants and …
b76ef00 
…landlords
@coxmars
feat: add escrow_xdr_transactions table with permissions for tenants …
8e0adb6 
…and landlords
@coxmars
feat: add escrow_api_calls table with permissions for tenants and lan…
7bf30b3 
…dlords
@coxmars
feat: add apartment_contracts table with permissions for tenants and …
9fcd869 
…landlords
@coxmars
feat: add JWT secret configuration for Hasura GraphQL
c485a4e
@coxmars
Copy link
Author

coxmars commented Feb 3, 2025

Hi @rvalenciano @diegoTech14 sorry for the delay, let me know if I need to apply changes, I will do it asap on Monday. 🫡

rvalenciano
rvalenciano reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@rvalenciano rvalenciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to update any documentation on the readme for the use of Firebase?

@sotoJ24 sotoJ24 self-requested a review February 4, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalenciano rvalenciano rvalenciano left review comments

@sotoJ24 sotoJ24 Awaiting requested review from sotoJ24

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure Role-Based Permissions for Database Tables
2 participants
@coxmars @rvalenciano