Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(Tx speed up): rm unused argument #4778

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Refactor(Tx speed up): rm unused argument #4778

merged 1 commit into from
Jan 15, 2025

Conversation

katspaugh
Copy link
Member

Just a tiny lint fix – the safeAddress param wasn't used in dispatchCustomTxSpeedUp.

@katspaugh katspaugh requested a review from schmanu January 15, 2025 11:44
Copy link

github-actions bot commented Jan 15, 2025

Copy link

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.04 MB (🟡 +54.14 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1.04 MB
/address-book 23.21 KB (🟡 +142 B) 1.06 MB
/apps 35.97 KB (🟡 +2.24 KB) 1.08 MB
/apps/custom 34.03 KB (🟡 +2.25 KB) 1.08 MB
/apps/open 55.57 KB (🟡 +1.96 KB) 1.1 MB
/balances 29.88 KB (🟡 +176 B) 1.07 MB
/balances/nfts 9.52 KB (🟢 -24 B) 1.05 MB
/bridge 2.56 KB (🟡 +2 B) 1.04 MB
/cookie 8.77 KB (🟡 +1 B) 1.05 MB
/home 61.54 KB (🟡 +2.28 KB) 1.1 MB
/new-safe/advanced-create 26.38 KB (🟢 -70 B) 1.07 MB
/new-safe/create 25.52 KB (🟢 -71 B) 1.07 MB
/privacy 14.57 KB (🟡 +2 B) 1.06 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.04 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.04 MB
/settings/modules 4.06 KB (🟡 +1 B) 1.05 MB
/settings/notifications 6.33 KB (🟢 -14.99 KB) 1.05 MB
/settings/safe-apps 20.35 KB (🟡 +2.08 KB) 1.06 MB
/settings/security 2.34 KB (🟡 +1 B) 1.04 MB
/settings/setup 30.83 KB (🟡 +94 B) 1.07 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.05 MB
/stake 618 B (🟢 -1 B) 1.04 MB
/swap 761 B (🟡 +1 B) 1.04 MB
/terms 12.93 KB (🟡 +1 B) 1.05 MB
/transactions 99.46 KB (🟡 +2.89 KB) 1.14 MB
/transactions/history 99.42 KB (🟡 +2.89 KB) 1.14 MB
/transactions/messages 60.25 KB (🟡 +1.95 KB) 1.1 MB
/transactions/msg 56.5 KB (🟡 +1.95 KB) 1.1 MB
/transactions/queue 49.36 KB (🟡 +1.96 KB) 1.09 MB
/transactions/tx 48.72 KB (🟡 +1.96 KB) 1.09 MB
/welcome/accounts 409 B (🟡 +2 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements 74.26% 14763/19880
🔴 Branches 52.03% 3537/6798
🔴 Functions 57.35% 2095/3653
🟡 Lines 75.8% 13397/17673

Test suite run success

1793 tests passing in 242 suites.

Report generated by 🧪jest coverage report action from f8b0b7f

@katspaugh katspaugh merged commit fdba84c into dev Jan 15, 2025
14 of 15 checks passed
@katspaugh katspaugh deleted the rm-arg branch January 15, 2025 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants